Skip to content

anki: 2.1.65 -> 2.1.66 + refactor#252981

Merged
wegank merged 2 commits intoNixOS:masterfrom
paveloom:anki
Sep 5, 2023
Merged

anki: 2.1.65 -> 2.1.66 + refactor#252981
wegank merged 2 commits intoNixOS:masterfrom
paveloom:anki

Conversation

@paveloom
Copy link
Copy Markdown
Member

@paveloom paveloom commented Sep 2, 2023

Description of changes

https://github.com/ankitects/anki/releases/tag/2.1.66

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@paveloom
Copy link
Copy Markdown
Member Author

paveloom commented Sep 2, 2023

Result of nixpkgs-review pr 252981 run on x86_64-linux 1

6 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • mnemosyne
  • mnemosyne.dist

@ofborg ofborg Bot requested review from euank and oxij September 2, 2023 17:59
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 2, 2023
Copy link
Copy Markdown
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the bits of refactoring as well!

Comment thread pkgs/games/anki/default.nix
@wegank wegank merged commit a0fa1b7 into NixOS:master Sep 5, 2023
@paveloom paveloom deleted the anki branch September 6, 2023 08:51
Comment thread pkgs/games/anki/default.nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants