Skip to content

butler: build with go_1_20#263551

Merged
marsam merged 1 commit intoNixOS:masterfrom
SuperSamus:butler-fix
Oct 27, 2023
Merged

butler: build with go_1_20#263551
marsam merged 1 commit intoNixOS:masterfrom
SuperSamus:butler-fix

Conversation

@SuperSamus
Copy link
Contributor

@SuperSamus SuperSamus commented Oct 26, 2023

Description of changes

Build failing since #254878.
Reported upstream on itchio/butler#256.

Some notes that are out of scope:
Itch itself has also regressed from the latest staging, and it still doesn't work:

[2420:1026/115924.099013:FATAL:gpu_data_manager_impl_private.cc(445)] GPU process isn't usable. Goodbye.

#248321 fixes it, but... it's using a beta.
(And --disable-gpu-sandbox still isn't enough, the application opens, but it's just a black screen)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 26, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2023
@marsam marsam merged commit 0bdbdbd into NixOS:master Oct 27, 2023
@SuperSamus SuperSamus deleted the butler-fix branch November 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants