itch: 25.6.2 -> 26.1.2

[SuperSamus]

Description of changes

While this new version is still a beta (some of the icons will be blue), the Electron version is not insecure anymore, with the number literally doubled (from 11 to 22).
Closes #220844 for real.
Closes #252457.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[davidak]

Result of nixpkgs-review pr 248321 run on x86_64-linux 1

1 package built:

• itch

[davidak]

Thanks for updating the package!

The beta/development/canary version is using a different namespace, so it does not use the existing data (login, installed games).

stable: /home/davidak/.config/itch/
canary: /home/davidak/.config/kitch/

That is by design: itchio/itch#1906

So it seem better to create a new package for the canary version to not confuse users.

kitch is the official name: https://itchio.itch.io/kitch which is also used by AUR.

Mention the different location in the package description. Otherwiese the meta from the stable package can be used.

Program works fine. Tested with games:

• https://cybereality.itch.io/ella-a-study-in-realism
• https://echo-heo.itch.io/placeholdername

[SuperSamus]

The idea of having both itch and kitch in nixpkgs doesn't convince me...
Maybe it's better to close this and wait for the stable release?

[davidak]

The idea of having both itch and kitch in nixpkgs doesn't convince me...

We have beta versions for other packages, like browsers. But it's an additional package for a different audience. If they offer it to users, why not package it?

Maybe it's better to close this and wait for the stable release?

This package has to be updated to the next stable version to keep working as the user expects.

[pasqui23]

I am trying to build it but itch-setup fails with the followig error:

error: builder for '/nix/store/1f6r4kk0zpv1p1xj7ps7z63hrwvk7i23-source.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://broth.itch.ovh/kkitch/linux-amd64/26.1.2/archive/default#.zip
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0    37    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download source from any mirror
       For full logs, run 'nix log /nix/store/1f6r4kk0zpv1p1xj7ps7z63hrwvk7i23-source.drv'.
error: 1 dependencies of derivation '/nix/store/xngr2cvq7x6k24gb3mblap1007rxzczb-kitch-26.1.2.drv' failed to build

[SuperSamus]

Reopening because Itch is now not working at all. With this, it works again.
I added a small modification so that the application still thinks it's Itch (instead of Kitch).
Tested both a Linux game (Baba is You) and a Windows game (Super Hexagon).

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2880

[SuperSamus]

Anything missing for this to be merged?

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2922