Closed
Conversation
Some parts of generated patches change from time to time, e.g. see NixOS#1983 and http://comments.gmane.org/gmane.linux.distributions.nixos/12815 Using fetchpatch should prevent the hash from changing.
This not only sorts the patch but also filters out duplicate files, currently all uses of fetchpatch lead to the same hashes so they're already sorted. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Member
|
See vcunat#1 for sorting. |
fetchpatch: Sort/filter patch by filenames.
Member
Author
|
Sorting+deduplication integrated. |
vcunat
added a commit
that referenced
this pull request
May 17, 2014
fetchpatch is fetchurl that determinizes the patch. Some parts of generated patches change from time to time, e.g. see #1983 and http://comments.gmane.org/gmane.linux.distributions.nixos/12815 Using fetchpatch should prevent the hash from changing. Conflicts (auto-solved): pkgs/development/libraries/haskell/gitit/default.nix
Member
Author
|
Pushed. Thanks to @aszlig for help! |
vcunat
added a commit
that referenced
this pull request
May 24, 2014
fetchpatch is fetchurl that determinizes the patch. Some parts of generated patches change from time to time, e.g. see #1983 and http://comments.gmane.org/gmane.linux.distributions.nixos/12815 Using fetchpatch should prevent the hash from changing. (cherry picked from commit 137eae0) Conflicts (simple, patchutils version from master): pkgs/development/libraries/haskell/gitit/default.nix pkgs/tools/text/patchutils/default.nix
This was referenced Sep 30, 2022
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
fetchpatch is fetchurl that determinizes the patch. Some parts of generated patches change from time to time, e.g. see NixOS#1983 and http://comments.gmane.org/gmane.linux.distributions.nixos/12815 Using fetchpatch should prevent the hash from changing. (cherry picked from commit 137eae0) Conflicts (simple, patchutils version from master): pkgs/development/libraries/haskell/gitit/default.nix pkgs/tools/text/patchutils/default.nix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #2570.