Skip to content

teleport_11: 11.3.10 -> 11.3.25, teleport_12: 12.4.7 -> 12.4.20, teleport_13: init at 13.4.1, teleport_14: init at 14.0.1#258943

Merged
risicle merged 6 commits intoNixOS:masterfrom
techknowlogick:bump-teleport
Oct 6, 2023
Merged

teleport_11: 11.3.10 -> 11.3.25, teleport_12: 12.4.7 -> 12.4.20, teleport_13: init at 13.4.1, teleport_14: init at 14.0.1#258943
risicle merged 6 commits intoNixOS:masterfrom
techknowlogick:bump-teleport

Conversation

@techknowlogick
Copy link
Copy Markdown
Member

@techknowlogick techknowlogick commented Oct 4, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added the 8.has: package (new) This PR adds a new package label Oct 4, 2023
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 4, 2023
@techknowlogick techknowlogick added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 4, 2023
@justinas
Copy link
Copy Markdown
Member

justinas commented Oct 5, 2023

Looks good, thanks for doing this.

Could you add an entry to 23.11 Release notes, similar to the one in 23.05 when we went from Teleport 10 to 12?

nixpkgs/nixos/doc/manual/release-notes/rl-2305.section.md

Line 108 in e831a3d

- `teleport` has been upgraded from major version 10 to major version 12. Please see upstream [upgrade instructions](https://goteleport.com/docs/setup/operations/upgrading/) and release notes for versions [11](https://goteleport.com/docs/changelog/#1100) and [12](https://goteleport.com/docs/changelog/#1201). Note that Teleport does not officially support upgrades across more than one major version at a time. If you're running Teleport server components, it is recommended to first upgrade to an intermediate 11.x version by setting `services.teleport.package = pkgs.teleport_11`. Afterwards, this option can be removed to upgrade to the default version (12).

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Oct 5, 2023
@techknowlogick
Copy link
Copy Markdown
Member Author

techknowlogick commented Oct 5, 2023

@justinas thanks for the feedback. I've added the changelog note :)

risicle
risicle approved these changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15 & nixos x86_64. All binaries run. nixosTests.teleport passes, nixos x86_64

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 5, 2023
@risicle risicle merged commit 3a60f9b into NixOS:master Oct 6, 2023
@techknowlogick techknowlogick deleted the bump-teleport branch October 6, 2023 20:05
@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 6, 2023
@justinas justinas mentioned this pull request Oct 7, 2023
Closed
12 tasks
@Tchekda
Copy link
Copy Markdown
Contributor

Tchekda commented Oct 8, 2023

Thank you very much for this PR!
I was trying to make it work but was struggling with the patches!

This was referenced Oct 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle approved these changes

@justinas justinas Awaiting requested review from justinas

@sigma sigma Awaiting requested review from sigma

@arianvp arianvp Awaiting requested review from arianvp

@tomberek tomberek Awaiting requested review from tomberek

@freezeboy freezeboy Awaiting requested review from freezeboy

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@techknowlogick @justinas @Tchekda @risicle @delroth