Skip to content

teleport_13: init at 13.3.8#241733

Closed
justinas wants to merge 1 commit intoNixOS:masterfrom
justinas:teleport-13
Closed

teleport_13: init at 13.3.8#241733
justinas wants to merge 1 commit intoNixOS:masterfrom
justinas:teleport-13

Conversation

@justinas
Copy link
Copy Markdown
Member

@justinas justinas commented Jul 5, 2023

Description of changes

New major version.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Jul 5, 2023
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 5, 2023
@justinas justinas marked this pull request as ready for review July 5, 2023 20:18
@justinas justinas changed the title teleport_13: init at 13.1.5 teleport_13: init at 13.3.2 Aug 16, 2023
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 16, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2553

@justinas justinas changed the title teleport_13: init at 13.3.2 teleport_13: init at 13.3.8 Sep 10, 2023
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Sep 10, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2644

@Tchekda
Copy link
Copy Markdown
Contributor

Tchekda commented Sep 27, 2023

Teleport v14 went public this week. It would be great to have it too.
I would love to help but I have no clue how this package is compiled

@justinas
Copy link
Copy Markdown
Member Author

justinas commented Sep 27, 2023

Teleport v14 went public this week. It would be great to have it too. I would love to help but I have no clue how this package is compiled

Will add v14 as well once I get the chance.

Tchekda
Tchekda approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tchekda Tchekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tchekda
Copy link
Copy Markdown
Contributor

Tchekda commented Sep 27, 2023

Teleport v14 went public this week. It would be great to have it too. I would love to help but I have no clue how this package is compiled

Will add v14 as well once I get the chance.

Would be awesome.

If you need maintainer review, maybe add the same maintainer that merged your previous teleport PR: arianvp ?

@TimoHocker
Copy link
Copy Markdown

TimoHocker commented Oct 7, 2023

Would be great to get this merged soon. All my nixos servers are now unreachable from teleport after upgrading my main server.

@justinas
Copy link
Copy Markdown
Member Author

justinas commented Oct 7, 2023

Sorry, forgot to close this one. This has already been obsoleted by #258943 . Teleport 13 & 14 are in nixos-unstable now.

@justinas justinas closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Tchekda Tchekda Tchekda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinas @nixos-discourse @Tchekda @TimoHocker