Skip to content

[staging-next] kubo: use buildGo120Module due to breakage after default go version bump#257901

Merged
fabianhjr merged 1 commit intoNixOS:staging-nextfrom
LibreCybernetics:fix-kubo-staging-next
Sep 30, 2023
Merged

[staging-next] kubo: use buildGo120Module due to breakage after default go version bump#257901
fabianhjr merged 1 commit intoNixOS:staging-nextfrom
LibreCybernetics:fix-kubo-staging-next

Conversation

@fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Sep 28, 2023 •
edited
Loading

Description of changes

Targetting: #257792

Bump: #254878

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabianhjr
Copy link
Member Author

fabianhjr commented Sep 28, 2023

Haven't tested, still building staging-next

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 28, 2023
Luflosi
Luflosi approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 29, 2023
@bct bct mentioned this pull request Sep 30, 2023
Merged
12 tasks
@fabianhjr fabianhjr merged commit 5603177 into NixOS:staging-next Sep 30, 2023
@fabianhjr fabianhjr deleted the fix-kubo-staging-next branch September 30, 2023 07:07
@Luflosi
Copy link
Contributor

Luflosi commented Oct 8, 2023

Kubo v0.23.0 is compatible with Go 1.21. Should we revert this after #259745 is merged and staging-next is merged into master or what is the best way to handle this?

@vcunat
Copy link
Member

vcunat commented Oct 8, 2023 •
edited
Loading

You could open that PR against staging-next branch and include the revert.
(and if staging-next gets merged sooner than that PR, simply retarget it to master)

@vcunat
Copy link
Member

vcunat commented Oct 8, 2023 •
edited
Loading

Or if the PR is expected to merge fast (to master), it's relatively easy to deal with this revert afterwards.

@Luflosi
Copy link
Contributor

Luflosi commented Oct 8, 2023

Okay, let's deal with it afterwards then.

@fabianhjr fabianhjr mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@zowoq zowoq Awaiting requested review from zowoq

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

1 more reviewer

@Luflosi Luflosi Luflosi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabianhjr @Luflosi @vcunat @delroth