Skip to content

coredns: 1.11.0 -> 1.11.1#258136

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
bct:coredns-1.11.1
Sep 30, 2023
Merged

coredns: 1.11.0 -> 1.11.1#258136
bjornfor merged 1 commit intoNixOS:masterfrom
bct:coredns-1.11.1

Conversation

@bct
Copy link
Contributor

@bct bct commented Sep 30, 2023

Description of changes

https://github.com/coredns/coredns/releases/tag/v1.11.1

This release fixes a major performance regression introduced in 1.11.0 that affected DoT (TLS) forwarded connections.
It also adds a new option to dnstap to add metadata to the dnstap extra field, and fixes a config parsing bug in cache.

This release also includes a change that allows coredns to build successfully with go 1.21, which should fix the coredns build on staging (since the default go version bump).

Things done

I successfully built coredns 1.11.1 on master and on staging.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bct bct mentioned this pull request Sep 30, 2023
12 tasks
@ofborg ofborg bot requested review from DeltaEvo, rtreffer and rushmorem September 30, 2023 02:25
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 30, 2023
@fabianhjr
Copy link
Member

Edited the merge request message to point to the go default version bump instead of the kubo go version change.

@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 258136 run on x86_64-linux 1

4 packages built:
  • coredns
  • coredns.man
  • kuma
  • kuma-experimental

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 30, 2023
@sikmir
Copy link
Member

sikmir commented Sep 30, 2023

Result of nixpkgs-review pr 258136 run on x86_64-darwin 1

4 packages failed to build:
  • coredns
  • coredns.man
  • kuma
  • kuma-experimental
       > --- FAIL: TestCorefile1 (0.00s)
       >     corefile_test.go:15: Expected an error got none
       > Not executing TestPrometheusImports: faillint not found
       > FAIL
       > FAIL       github.com/coredns/coredns/test 7.101s
       > FAIL

@bct
Copy link
Contributor Author

bct commented Sep 30, 2023

@kirillrdy On an earlier PR you pointed out that TestCorefile1 has been broken on darwin since nixpkgs upgraded to 1.11.0, and reported the failure upstream (coredns/coredns#6289). Did you learn anything more about it?

@bjornfor bjornfor merged commit ca80f30 into NixOS:master Sep 30, 2023
@kirillrdy
Copy link
Member

@kirillrdy On an earlier PR you pointed out that TestCorefile1 has been broken on darwin since nixpkgs upgraded to 1.11.0, and reported the failure upstream (coredns/coredns#6289). Did you learn anything more about it?

As per upstream bug report TestCorefile1 was failing on older macos, upgrading to latest fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants