cc-wrapper: don't use fortify-headers for non-gcc compilers#251942
Merged
risicle merged 1 commit intoNixOS:masterfrom Aug 28, 2023
Merged
cc-wrapper: don't use fortify-headers for non-gcc compilers#251942risicle merged 1 commit intoNixOS:masterfrom
fortify-headers for non-gcc compilers#251942risicle merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
12 tasks
Contributor
|
Testing this now |
Contributor
Author
|
Going to re-target this to master as it should only cause rebuilds for clang/musl users, where things are already a bit broken. |
risicle
force-pushed
the
ris-fortify-headers-disable-non-gcc
branch
from
54d8b16 to
df02fcb
Compare
Contributor
Author
|
Breaking the glass.. |
Contributor
|
Can confirm this fixes pkgsMusl.thunderbird-unwrapped. Thanks for following up on this (and generally putting work into the musl toolchain) 🎉 |
yu-re-ka
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a break-glass-if-we-get-too-frustrated PR to completely disable use of fortify-headers for non-gcc compilers. There are several cases where use of the fortify-headers will totally confuse clang, and they're hard to debug.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)