fortify-headers: 1.1alpine1 -> 1.1alpine3#251768
Conversation
61a5b26 to
dbe7ef1
Compare
|
On second thoughts this probably isn't urgent enough to go to |
|
Since it doesn't have many (hydra) rebuilds, I think it should go into master. |
|
Well, it's a full rebuild for musl users. |
|
define "musl users". I have a device that's running full nixos with musl, but that can't be upgraded to current master because of too many build failures being introduced in the last two staging cycles, some of which would be fixed by this. |
|
Well it's more that I foresee having to add a couple more fixes for this, and it would be better to trigger rebuilds for people once, rather that twice or three times. Would it be better if we merged #251942 to make this a completely non-urgent problem? |
|
|
|
which PR introduced the fortify-headers for musl libc then? |
|
No wait, you're right - I've got my numbers mixed up. |
|
Let's merge this into staging and #251942 into master, and then we're good for now and can figure out how to make it work with clang at some point |
Description of changes
The relevant changes in this bump are the addition of some patches fixing behaviour with clang. I think we're still going to have to patch fortify-headers further to make it more easily disable-able for clang (if not just disable it entirely for clang) but this is a start.
Have built a lot of
pkgsMuslpackages on nixos x86_64 with this.cc @NixOS/static
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)