Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mommy: init at 1.2.3 #250034

Merged
merged 1 commit into from
Aug 19, 2023
Merged

mommy: init at 1.2.3 #250034

merged 1 commit into from
Aug 19, 2023

Conversation

ckiee
Copy link
Member

@ckiee ckiee commented Aug 18, 2023

Description of changes

mommy's here to support you, in any shell, on every NixOS system~ ❤️

an opt-in wrapper is included to configure mommy— once mommy is configured with pkgs.mommy.override you can take her store path with you to other machines.

cc @FWDekker

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/tools/misc/mommy/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/mommy/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/mommy/default.nix Show resolved Hide resolved
@cafkafk
Copy link
Member

cafkafk commented Aug 19, 2023

Result of nixpkgs-review pr 250034 run on x86_64-linux 1

1 package built:
  • mommy

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, local testing indicates this is working as expected, e.g.:
2023-08-19_02-30

@donovanglover donovanglover added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Aug 19, 2023
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked x86_64-darwin and aarch64-darwin since the ofborg build was still in queue and they succeeded. This looks good to me now, thank you!

@lilyinstarlight lilyinstarlight merged commit 6d14773 into NixOS:master Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants