-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🫣 mommy finds your config with an environment variable now~ +nixos #61
🫣 mommy finds your config with an environment variable now~ +nixos #61
Conversation
f5db850
to
d578552
Compare
she is off her flight and has arrived at nixos now |
netbsd appears to not be working, but probably because something's wrong with the vm / script. i'll try to debug it locally, not sure how long that will take |
i think (hope) the issues have been fixed, time will tell. (edit: time did tell, they're fixed!) btw, thank you very much for opening this issue, and for taking mommy on a trip to nixos! she's very excited to go there! let me know if there are any issues you encounter or troubles you have. i don't have a lot of time on my hands at all right now, but i will do my best ^^ btw, are there any special installation instructions users should be aware of for nixos? would be great if you could add those to the readme! and would you mind rebasing your pr onto the dev branch? |
71806bc
to
bbc4021
Compare
rebasing breaks git atm, presumably because of:
so mommy has now taught git how to not make a mess (: also rebased |
yes! the nix package uses this PR to let creatures configure mommy from within nix-the-language: pkgs.mommy.override {
mommySettings.sweetie = "catgirl";
} the catch is, nix is a vast ecosystem with a lot of "distros" (NixOS, nix-darwin, NixOS-WSL, home-manager, standalone i'm not sure when, but i'll eventually try to PR something that works Well Enough 💜 |
very nice! i wasn't aware that you could combine
i see. i still think it would be valuable to add it to the readme so that others know that release channel exists. now, i'm absolutely not familiar with nixos (and regret to say i don't have time to delve much deeper) but i just read up on it a little bit. what do you think of adding a subsection "nix/nixos" (include both, so people don't confuse it with "*nix") in the readme under "with a package manager" in which you add a list item "nixpkgs (automatic or manual updates)" where you say something like
(you can mommy-ify the use of language if you want, of course) from my understanding, this allows us to show off your work of having a package on nixpkgs ✨, allows users to quickly try out mommy without configuration and without permanent side effects, and still links users to the more advanced information if they want it. what do you think?
what do you mean? don't you think it currently works well enough? ^^' |
fc31d34
to
c107dec
Compare
done! :3
yes! but the instructions there (or anywhere else i could think of) weren't very useful, so i wrote my own. we also added CI because i wanted to add to the "mommy is tested on the ci seems to work too, (netbsd fails tho!) but it's a bit scary because the output doesn't seem to be displayed, but running it locally shows it is running
i was referring to the missing docs, and now they are good too~ cya again soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm happy. just have a few questions so i understand this correctly so that i don't break things in the future :-) (...and one minor change request)
cya again soon!
👋
git was getting confused and trying to run some CRLF conversion, so we, as i understand, allow it to guess whether a file is binary or text. https://stackoverflow.com/a/46592252
…G basedir) xdg: it is very important mommy can find her girl's instructions even when they are scribbled down in an unusual place! https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
c107dec
to
efceb22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! thank you very much for your work! i'll merge this pr now, later today i'll add you to the list of contributors and i'll do a little bit more nitpicking ^^
watch out for this little creature!
|
yes, i noticed it, and though i allowed the new actions, i was unable to re-run the actions because of the specific type of error, so i'll have to postpone that to the next commit. thanks for the heads up! ^^ |
hi @ckiee! brief question: i see on the list of nixos packages that mommy is at v1.2.3 (which i believe is secretly the same as v1.2.4 because you included patches), but still makes it look like the package is outdated. does updating mommy on nixpkgs require a pr in nixos/nixpkgs or will the update happen automatically once a new github release for mommy is made? |
hi ^^ it probably wouldn't work here, because the just made the pr: NixOS/nixpkgs#266090 |
thank you! if the bot doesn't detect future releases i think i'll just use @FWDekkerBot to automatically create prs for nixpkgs in the future. it currently already does that for homebrew and aur anyway~ |
i taught mommy this with a js regex:/(MOMMY_[\w_]+)=("[\s\S]*?")/
, replaced matches w$1=${$1:-$2}\n
on regexrmommy will usually use her default settings~
i am bringing mommy on a field trip to nixpkgs (home of nixos), she is on flight number NixOS/nixpkgs#250034.
edit: i just noticed mommy already reads a config file in your home, i think it would be good if
MOMMY_OPT_CONFIG_FILE
was an env var instead