python3Packages.sphinxHook: Fix cross compilation#249157
Merged
Artturin merged 1 commit intoNixOS:masterfrom Sep 9, 2023
Merged
python3Packages.sphinxHook: Fix cross compilation#249157Artturin merged 1 commit intoNixOS:masterfrom
Artturin merged 1 commit intoNixOS:masterfrom
Conversation
12 tasks
4f4f118 to
2da3714
Compare
Contributor
Author
|
Changed target branch to staging and rebased due to number of rebuilds. |
FRidh
approved these changes
Aug 25, 2023
100ae35 to
c7454bd
Compare
Member
|
hooks/default change no longer necessary since #247245 |
Contributor
Author
|
Just rebased with staging to be sure, but it still fails to cross compile wrap without this, with the same error |
Artturin
approved these changes
Sep 9, 2023
Member
There was a problem hiding this comment.
Sorry I forgot that my pr only fixed splicing python3Packages.callPackage { python }: while the hook splicing within the set (used by callPackage) is still broken and will eventually be fixed by #228139
the rebuilds are a bit weird so i'll check why that is happening
Artturin
reviewed
Sep 9, 2023
c7454bd to
2177094
Compare
Failed due to using host sphinx instead of build one.
2177094 to
a391639
Compare
Member
|
I checked and there's really no rebuilds, rebuild count is likely just because of a rebase gone wrong |
kip93
added a commit
to OroraTech/nixpkgs
that referenced
this pull request
Sep 30, 2023
Fixes some side effects of NixOS#249157 (see NixOS#255810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build of wrapt. Also removed the now irrelevant workaround on beautifulsoup4.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)