Skip to content

Comments

treewide: noop: refer to src.name or similar in sourceRoot where appropriate, part 4: leftovers#248528

Merged
drupol merged 1 commit intoNixOS:masterfrom
oxij:tree/source-root-continues-2
Aug 11, 2023
Merged

treewide: noop: refer to src.name or similar in sourceRoot where appropriate, part 4: leftovers#248528
drupol merged 1 commit intoNixOS:masterfrom
oxij:tree/source-root-continues-2

Conversation

@oxij
Copy link
Member

@oxij oxij commented Aug 11, 2023

Continues where #245388 and #247977 left off.

This replaces all the leftover references to fetchzip's "source" in sourceRoot package attribute with src.name and similar.

A noop, build-wise.

…appropriate, part 4: leftovers

This continues where eaafc0f.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 11, 2023
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 11, 2023
@drupol drupol merged commit 494522a into NixOS:master Aug 11, 2023
@oxij
Copy link
Member Author

oxij commented Aug 12, 2023

Thanks again, @AndersonTorres!

And thanks, @drupol!

(Late unsneaky ninja edit, yesss.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants