treewide: mostly noop: refer to src.name or similar in sourceRoot where appropriate#245388
treewide: mostly noop: refer to src.name or similar in sourceRoot where appropriate#245388mweinelt merged 5 commits intoNixOS:masterfrom
src.name or similar in sourceRoot where appropriate#245388Conversation
|
Rebased onto master to fix a conflict with |
I know, but what I'm saying here is a bit different... I'm saying that we should avoid using |
|
The removal of rec can be done in other PRs. |
|
OfBorg seems to be stuck? Pending eval for 20 hours. |
|
@drupol I pushed a new commit that replaces all newly introduced |
|
Excellent, thanks !!!! |
aarch64-darwin usually spends days bootstrapping. |
|
Yay! All checks pass, still no conflicts. A prime opportunity to merge. :) |
|
Except merge conflicts. Maybe because I burned it up :( |
…appropriate, part 1: trivial cases
…appropriate, part 2: the non-trivial cases
…plementation, fix examples
…ec` with a fixpoint over `finalAttrs`
|
Rebased. |
|
🍻 |
|
This now has a continuation in #247977. |
Description of changes
This replaces all the uses of
sourceRoot = "source";,sourceRoot = "source/subdir";, and similar in package derivations that use the defaultunpackPhasewithsourceRoot = src.name,sourceRoot = "${src.name}/subdir";and similar.It also fixes
sourceRootandsetSourceRootdescription in the docs to match the implementation, and deprecates the old usage in release notes.The primary motivation for this change is to make #49862 (or its reverse) trivial to implement.
Things done
It's a mostly noop change except for the changes to documentation (which cause
nixos-install-toolsto be rebuilt).