makeBinaryWrapper: remove cc dependency on aarch64-darwin#247164
Merged
ncfavier merged 1 commit intoNixOS:stagingfrom Aug 5, 2023
tjni:make-wrapper-dependencies
Merged
makeBinaryWrapper: remove cc dependency on aarch64-darwin#247164ncfavier merged 1 commit intoNixOS:stagingfrom tjni:make-wrapper-dependencies
ncfavier merged 1 commit intoNixOS:stagingfrom
tjni:make-wrapper-dependencies
Conversation
Contributor
Author
|
I was able to build @ncfavier would you be a good person to review this change? |
ncfavier
approved these changes
Aug 4, 2023
Member
|
@ofborg build makeBinaryWrapper makeBinaryWrapper.tests |
Contributor
Author
|
Thank you for kicking off those builds. I'll change the commit message to |
Member
Contributor
Author
|
Interesting! From ofborg: |
Contributor
Author
|
That failure also occurs on @ofborg build makeBinaryWrapper makeBinaryWrapper.tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This intends to address #172249 on aarch64-darwin (which was reverted in #174038). I think it should be possible now that #238323 is committed.
I am still building and testing this locally.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)