makeBinaryWrapper: fix codesign on aarch64-darwin#174038
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom May 23, 2022
Merged
makeBinaryWrapper: fix codesign on aarch64-darwin#174038vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
Reverts 8b79ef2 on aarch64-darwin, no-op on other platforms.
13 tasks
ofborg
bot
added
6.topic: darwin
ncfavier
changed the title
Member
|
So you have tested that it fixes the regression? (in one case at least) |
Member
Author
|
No, I don't have an aarch64-darwin machine. |
Member
|
A good idea. I think that's sufficient assurance at this point. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172749 (comment)
Reverts 8b79ef2 on aarch64-darwin, no-op on other platforms.
I don't know for sure what's going on, but given that the issue involves code signing, and#172749 (comment)ccwas originally added todepsto fix code signing issues, I think this is likely to fix the issue.(Adding
ccto the propagated build inputs is still not great, so unless #148189 gets fixed we will probably want to refine that to something likebuildEnv { paths = [ cctools ]; pathsToLink = [ "/bin/codesign_allocate" ]; }, but now is not the time to experiment.)