Skip to content

nixos-generate-config: add 'lib' arg to configuration.nix #244653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roberth merged 1 commit into from
Jul 23, 2023
Merged

nixos-generate-config: add 'lib' arg to configuration.nix #244653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nixos/modules/installer/tools/tools.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ in
# your system. Help is available in the configuration.nix(5) man page
# and in the NixOS manual (accessible by running `nixos-help`).

{ config, pkgs, ... }:
{ config, lib, pkgs, ... }:
Copy link
Member

@RaitoBezarius RaitoBezarius Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not go all the way and put options, utils and add a comment to document them?

Copy link
Member

@ncfavier ncfavier Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options is basically only useful to module authors and probably distracting for beginners, and I think utils is frowned upon

Copy link
Member

@RaitoBezarius RaitoBezarius Jul 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it


{
imports =
Expand Down