nixos-generate-config: add 'lib' arg to configuration.nix#244653
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 23, 2023
Merged
nixos-generate-config: add 'lib' arg to configuration.nix#244653roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
Although 'lib' isn't needed by the default configuration, new NixOS uses can get confused when being recommended configuration.nix snippets like systemd.services.NetworkManager-wait-online.enable = lib.mkForce false; and have `sudo nixos-rebuild switch` fail with error: undefined variable 'lib'
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
@SuperSandro2000, @roberth: Can you please review? (You're the last people to touch this file.) |
| # and in the NixOS manual (accessible by running `nixos-help`). | ||
|
|
||
| { config, pkgs, ... }: | ||
| { config, lib, pkgs, ... }: |
Member
There was a problem hiding this comment.
Why not go all the way and put options, utils and add a comment to document them?
Member
There was a problem hiding this comment.
options is basically only useful to module authors and probably distracting for beginners, and I think utils is frowned upon
ncfavier
approved these changes
Jul 23, 2023
roberth
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Although 'lib' isn't needed by the default configuration, new NixOS uses
can get confused when being recommended configuration.nix snippets like
and have
sudo nixos-rebuild switchfail withThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)