Skip to content

curl: 8.1.2 -> 8.2.0#244468

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
yayayayaka:curl-8.2.0
Jul 26, 2023
Merged

curl: 8.1.2 -> 8.2.0#244468
vcunat merged 1 commit intoNixOS:stagingfrom
yayayayaka:curl-8.2.0

Conversation

@yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented Jul 20, 2023 •
edited by mweinelt
Loading

Description of changes

https://curl.se/changes.html#8_2_0

Fixes CVE-2023-32001

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yayayayaka yayayayaka added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-23.05 labels Jul 20, 2023
@yayayayaka yayayayaka requested a review from mweinelt July 20, 2023 09:05
@mweinelt
Copy link
Member

mweinelt commented Jul 20, 2023

23.05 is on curl 8.0.1 and we only backport security patches, not full releases, for it.

@yayayayaka
Copy link
Member Author

yayayayaka commented Jul 20, 2023

Appiled the patch instead for 23.05: #244475

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Jul 20, 2023
@ofborg ofborg bot requested a review from lovek323 July 20, 2023 14:16
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 20, 2023
@risicle
Copy link
Contributor

risicle commented Jul 23, 2023

Successfully built most of passthru.tests on macos 10.15 (only limited by time)

@vcunat vcunat self-assigned this Jul 26, 2023
@vcunat vcunat merged commit 1e243bd into NixOS:staging Jul 26, 2023
@yayayayaka yayayayaka deleted the curl-8.2.0 branch July 28, 2023 16:39
@vcunat
Copy link
Member

vcunat commented Aug 2, 2023

@Izorkin: curlHTTP3 broke. I suspect it will need some tweaks around ngtcp2 and nghttp3 versions.
https://hydra.nixos.org/build/229854064/nixlog/2/tail
curl/curl@993b149

I hope these breakages will improve after the soon-to-come ngtcp2 1.0.

@Izorkin
Copy link
Contributor

Izorkin commented Aug 2, 2023

@vcunat needed this PR - #236613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees

@vcunat vcunat

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yayayayaka @mweinelt @risicle @vcunat @Izorkin