Skip to content

ngtcp2: 0.15.0 -> 0.17.0 #236613

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
Izorkin:update-http3-libs
Aug 2, 2023
Merged

ngtcp2: 0.15.0 -> 0.17.0 #236613
vcunat merged 1 commit intoNixOS:staging-nextfrom
Izorkin:update-http3-libs

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 8, 2023

Description of changes

Update ngtcp2 to version 0.17.0.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 8, 2023
@Izorkin Izorkin force-pushed the update-http3-libs branch from 73e4090 to 6f53647 Compare July 25, 2023 14:07
@mweinelt mweinelt requested a review from ajs124 July 25, 2023 14:12
@Izorkin Izorkin force-pushed the update-http3-libs branch from 6f53647 to 6834a21 Compare July 25, 2023 14:40
@Izorkin Izorkin force-pushed the update-http3-libs branch from 6834a21 to acf841e Compare July 25, 2023 14:51
@SuperSandro2000 SuperSandro2000 changed the title Update http3 libraries ngtcp2: 0.15.0 -> 0.17.0 Jul 25, 2023
@SuperSandro2000
Copy link
Member

With this rebuild count we can also target master

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 25, 2023

With this rebuild count we can also target master

Requires one of the latest versions of curl.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 25, 2023

Requires curl 8.2.0:

checking for explicit_bzero... yes
checking for explicit_memset... no
make[2]: Leaving directory '/build/curl-8.1.2/lib'
make[1]: *** [Makefile:1507: all] Error 2
make[1]: Leaving directory '/build/curl-8.1.2/lib'
make: *** [Makefile:1267: all-recursive] Error 1
error: builder for '/nix/store/msj8l0hwqzav248nypk32q0ilj8b7hb1-curl-8.1.2.drv' failed with exit code 2;
       last 10 log lines:
       > vquic/curl_ngtcp2.c:36:10: fatal error: ngtcp2/ngtcp2_crypto_openssl.h: No such file or directory
       >    36 | #include <ngtcp2/ngtcp2_crypto_openssl.h>
       >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > compilation terminated.
       > make[2]: *** [Makefile:3274: vquic/libcurl_la-curl_ngtcp2.lo] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > make[2]: Leaving directory '/build/curl-8.1.2/lib'
       > make[1]: *** [Makefile:1507: all] Error 2
       > make[1]: Leaving directory '/build/curl-8.1.2/lib'
       > make: *** [Makefile:1267: all-recursive] Error 1
       For full logs, run 'nix log /nix/store/msj8l0hwqzav248nypk32q0ilj8b7hb1-curl-8.1.2.drv'.

@ajs124
Copy link
Member

ajs124 commented Jul 26, 2023

@ofborg eval

@ajs124 ajs124 mentioned this pull request Jul 26, 2023
@Izorkin Izorkin force-pushed the update-http3-libs branch from acf841e to 01234fa Compare July 27, 2023 12:49
@Izorkin Izorkin mentioned this pull request Aug 2, 2023
12 tasks
@Izorkin Izorkin requested a review from vcunat August 2, 2023 10:45
@vcunat
Copy link
Member

vcunat commented Aug 2, 2023

Right now, staging-next should be the best target branch. #245935

@vcunat vcunat changed the base branch from staging to staging-next August 2, 2023 11:02
@vcunat
Copy link
Member

vcunat commented Aug 2, 2023

Ah, I didn't realize that this is an older PR, so retargeted.

@vcunat vcunat merged commit bd45c59 into NixOS:staging-next Aug 2, 2023
@vcunat
Copy link
Member

vcunat commented Aug 2, 2023

Ah, OK. I was searching for wrong keywords and thus missed this PR.

@Izorkin Izorkin deleted the update-http3-libs branch August 2, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants