Merged
Conversation
- Switch to `finalAttrs` pattern. - Move `DESTDIR` into `env`. - Use `lib.optionals` for patches and move the comment inside, in preparation for more patches.
- Fixes flaky test with libgupower 238. - Adds support for installed tests. https://gitlab.freedesktop.org/upower/upower/-/compare/v1.90.0...v1.90.1 https://gitlab.freedesktop.org/upower/upower/-/compare/v1.90.1...v1.90.2
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
11.by: package-maintainer
trofi
approved these changes
Jul 13, 2023
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Works for me on staging. Thank you!
| umockdev | ||
|
|
||
| # For installed tests. | ||
| (python3.withPackages (pp: [ |
Member
|
Was upower before this update also flaky when running the tests? I have encountered multiple issues today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)