Skip to content

libgudev: 237 → 238#241939

Merged
jtojnar merged 3 commits intoNixOS:stagingfrom
jtojnar:libgudev
Jul 11, 2023
Merged

libgudev: 237 → 238#241939
jtojnar merged 3 commits intoNixOS:stagingfrom
jtojnar:libgudev

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Jul 6, 2023

Description of changes

cc @flokli for umockdev changes

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Jul 6, 2023
Merged
12 tasks
flokli
flokli approved these changes Jul 6, 2023
View reviewed changes
pkgs/development/libraries/umockdev/default.nix
'';

passthru = {
# libgudev is needed for an optional test but it itself relies on umockdev for testing.
Copy link
Member

@flokli flokli Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooh, interesting bootstrapping problem :-D But LGTM 👍

@flokli
Copy link
Member

flokli commented Jul 6, 2023

Didn't check if it builds.

@ofborg ofborg bot requested review from dasj19, edolstra, flokli and hedning July 6, 2023 17:19
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 6, 2023
@mweinelt mweinelt added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 7, 2023
@jtojnar jtojnar mentioned this pull request Jul 8, 2023
Merged
12 tasks
@Alanazane
Copy link

Alanazane commented Jul 8, 2023

After Arch updated to 238 Steam is failing to launch for some users, this was found to not be a libgudev issue but a Steam one. Figured it might be worth noting here just in case Steam doesn't fix the issue before this is set to land.
However I was unable to reproduce the bug after rebuilding with this branch, so it may not effect users NixOS regardless :)

Steam issue for the bug here: ValveSoftware/steam-for-linux#9805

@jtojnar
Copy link
Member Author

jtojnar commented Jul 8, 2023

Reading the upstream issue, it is a clash between system and steam-runtime libgudev. Our steam-run does not appear to contain libgudev so I guess we are fine.

@jtojnar jtojnar merged commit 39e6cff into NixOS:staging Jul 11, 2023
@jtojnar jtojnar deleted the libgudev branch July 11, 2023 13:29
@soupglasses soupglasses mentioned this pull request Jul 11, 2023
Closed
@trofi
Copy link
Contributor

trofi commented Jul 13, 2023

Bisect says commit eafa5c9 libgudev: 237 → 238 broke upower test:

$ nix build --no-link -f. -L upower
...
upower> Summary of Failures:
upower> 29/58 Tests.test_hidpp_touchpad                                  FAIL            0.49s   exit status 1
upower> 32/58 Tests.test_hidpp_touchpad_race                             FAIL            0.74s   exit status 1

@jtojnar
Copy link
Member Author

jtojnar commented Jul 13, 2023

Ugh, we noticed there were some flaky tests in #241586 (comment) but did not bump it because it required libgudev 238. I guess it is safe to bump now, opened #243217

@lilyinstarlight lilyinstarlight mentioned this pull request Jul 27, 2023
Closed
13 tasks
@ghost ghost mentioned this pull request Aug 2, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@amaxine amaxine Awaiting requested review from amaxine

@Artturin Artturin Awaiting requested review from Artturin

@hedning hedning Awaiting requested review from hedning

@edolstra edolstra Awaiting requested review from edolstra

@dasj19 dasj19 Awaiting requested review from dasj19

@flokli flokli Awaiting requested review from flokli

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jtojnar @flokli @Alanazane @trofi @mweinelt