Merged
Conversation
Contributor
Author
|
@wegank may I ask you for a review? |
12 tasks
Member
|
I guess I don't have the computing power for the review, but I'll try to get the commit dropping |
Contributor
Author
Isn't that one of the reasons |
12 tasks
Member
|
This is probably what broke all compiled /cc their maintainer @7c6f434c |
Member
|
We can probably just use boost 1.79 for libre office |
This was referenced Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates boost to the most recent version minus one. The idea is to stay behind one release in the hope that most of the breakage caused by that version has been resolved in the upstreams in the meantime.
This also removes the
boost17xandboost18xaliases. They suggested that the inner numbers7and8represent some kind of minor version, which is not the case.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)