Skip to content

Comments

boost: default to 1.8.2#227860

Closed
tobim wants to merge 1 commit intoNixOS:stagingfrom
tobim:staging
Closed

boost: default to 1.8.2#227860
tobim wants to merge 1 commit intoNixOS:stagingfrom
tobim:staging

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Apr 23, 2023

Description of changes

There is no documented reason to pin the default version to a somewhat arbitrary release. Let's see if we can lift it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 23, 2023
@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

I suppose this would better wait past 23.05 (forking off), at this point.

@tobim
Copy link
Contributor Author

tobim commented Apr 27, 2023

I suppose this would better wait past 23.05 (forking off), at this point.

I wouldn't mind.

@tobim tobim changed the title boost: default to 1.8.1 boost: default to 1.8.2 Apr 28, 2023
@tobim
Copy link
Contributor Author

tobim commented May 28, 2023

Maybe we should stay one release behind to reduce the patching burden.

@tobim
Copy link
Contributor Author

tobim commented Jun 26, 2023

@vcunat what do you think?

@vcunat
Copy link
Member

vcunat commented Jun 26, 2023

I got no idea about the boost ecosystem, really.

@tobim
Copy link
Contributor Author

tobim commented Jun 27, 2023

If we do it that we way should also remove the boost1xx aliases. Having boost18x point to 1.82, but boost to 1.81 would be confusing.

CC @hjones2199 as maintainer.
CC @wegank, who got rid of a lot of old versions recently.

@wegank
Copy link
Member

wegank commented Jun 27, 2023

Removing boost17x sounds good to me.

@tobim
Copy link
Contributor Author

tobim commented Jun 29, 2023

#240604

@tobim tobim closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants