Skip to content

Comments

go_1_20: 1.20.4 -> 1.20.5#237957

Closed
mdwn wants to merge 1 commit intoNixOS:masterfrom
mdwn:go-1.20.4-to-1.20.5
Closed

go_1_20: 1.20.4 -> 1.20.5#237957
mdwn wants to merge 1 commit intoNixOS:masterfrom
mdwn:go-1.20.4-to-1.20.5

Conversation

@mdwn
Copy link

@mdwn mdwn commented Jun 15, 2023

Changelog: https://go.dev/doc/devel/release#go1.20

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mdwn mdwn requested review from Mic92, kalbasit and zowoq as code owners June 15, 2023 17:06
@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Jun 15, 2023
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 15, 2023
@ofborg ofborg bot requested a review from qbit June 15, 2023 17:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 15, 2023
@apfelkuchen6
Copy link
Contributor

Hello,

Updates to packages that a lot of otther packages depend on need to go to the staging branch first, since all these reverse-dependencies have to be rebuilt and merging into master would block the unstable channel until all these rebuilds have been done.

A pull request #236359 for go-1.20.5 has already been merged into staging and will land in master with #237233, which should be merged into master in the fext week or so.

Thanks for contributing :)

@mdwn
Copy link
Author

mdwn commented Jun 15, 2023

Thanks for the heads up, sorry for the noise! Will close.

@mdwn mdwn closed this Jun 15, 2023
@mdwn mdwn deleted the go-1.20.4-to-1.20.5 branch June 15, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants