Skip to content

Comments

go_1_20: 1.20.4 -> 1.20.5#236359

Merged
drupol merged 1 commit intoNixOS:stagingfrom
qowoz:go120
Jun 7, 2023
Merged

go_1_20: 1.20.4 -> 1.20.5#236359
drupol merged 1 commit intoNixOS:stagingfrom
qowoz:go120

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 6, 2023

Changelog: https://go.dev/doc/devel/release#go1.20

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jun 6, 2023
@zowoq zowoq requested review from Mic92 and kalbasit as code owners June 6, 2023 21:11
@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Jun 6, 2023
@ofborg ofborg bot requested a review from qbit June 7, 2023 00:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 7, 2023
@drupol drupol merged commit 428c26a into NixOS:staging Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Successfully created backport PR for staging-23.05:

@zowoq zowoq deleted the go120 branch June 7, 2023 21:58
@noaccOS noaccOS mentioned this pull request Jun 14, 2023
Merged
@apfelkuchen6 apfelkuchen6 mentioned this pull request Jun 15, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

+2 more reviewers

@marsam marsam marsam approved these changes

@qbit qbit qbit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zowoq @marsam @qbit @drupol