Skip to content

frida-tools: fix eval#236828

Merged
K900 merged 1 commit intoNixOS:masterfrom
K900:fix-frida-tools-eval
Jun 9, 2023
Merged

frida-tools: fix eval#236828
K900 merged 1 commit intoNixOS:masterfrom
K900:fix-frida-tools-eval

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Jun 9, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900 K900 requested a review from s1341 June 9, 2023 11:43
@K900 K900 merged commit f0cbc8c into NixOS:master Jun 9, 2023
@s1341
Copy link
Contributor

s1341 commented Jun 9, 2023

Why does ci not catch these things? Apologies in any case.

@vcunat vcunat mentioned this pull request Jun 9, 2023
12 tasks
@K900
Copy link
Contributor Author

K900 commented Jun 9, 2023

NixOS/ofborg#643

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 9, 2023
@K900 K900 deleted the fix-frida-tools-eval branch July 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants