frida-tools: init at 12.1.2

[s1341]

Description of changes

Init frida-tools, and it's dependency frida-python.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[RaitoBezarius]

Some rework has to be done

[RaitoBezarius]

Some rework has to be done

[s1341]

Thanks for the review. I've addressed all your requests, I believe.

[VergeDX]

Tested, works fine for me, thanks for contribution!

[SuperSandro2000]

Can you squash the review commits into the init ones?

[s1341]

Squashed!

[panicgh]

I don't know why, but this pops up when I run nixpkgs-review (for any of my branches, so also for master). Maybe this PR somehow broke nixpkgs-review?

Trace

[abc:~/nixpkgs]$ git checkout master
[abc:~/nixpkgs]$ git pull --ff-only origin master
[abc:~/nixpkgs]$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs 8a64294cea1b0e5ccce96d7a08a53b6c64a598f7
Preparing worktree (detached HEAD 8a64294cea1)
Updating files: 100% (35564/35564), done.
HEAD is now at 8a64294cea1 Merge pull request #236701 from fabaff/waterfurnace-pytest-runner
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
error:
       … while querying the derivation named 'frida-tools-12.1.2'

       … while evaluating the attribute 'out.outPath'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/customisation.nix:215:13:

          214|             drvPath = assert condition; drv.${outputName}.drvPath;
          215|             outPath = assert condition; drv.${outputName}.outPath;
             |             ^
          216|           } //

       … while evaluating the attribute 'nativeBuildInputs' of the derivation 'frida-tools-12.1.2'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:303:7:

          302|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          303|       name =
             |       ^
          304|         let

       … while evaluating call site

       at «none»:0: (source not available)

       … while calling 'chooseDevOutputs'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/attrsets.nix:959:5:

          958|     # List of packages to pick `dev` outputs from
          959|     drvs:
             |     ^
          960|     builtins.map getDev drvs;

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:244:51:

          243|       (map (drv: drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild))
          244|       (map (drv: drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs'))
             |                                                   ^
          245|       (map (drv: drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget))

       … while calling 'checkDependencyList''

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:216:43:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                           ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:216:49:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                                 ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … while calling 'flip'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/trivial.nix:138:16:

          137|   */
          138|   flip = f: a: b: f b a;
             |                ^
          139|

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/trivial.nix:138:19:

          137|   */
          138|   flip = f: a: b: f b a;
             |                   ^
          139|

       … while calling 'imap1'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/lists.nix:117:14:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |              ^
          118|

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:181:10:

          180|       pythonRemoveBinBytecodeHook
          181|     ] ++ lib.optionals (lib.hasSuffix "zip" (attrs.src.name or "")) [
             |          ^
          182|       unzip

       … while calling 'optionals'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/lists.nix:301:5:

          300|     # List to return if condition is true
          301|     elems: if cond then elems else [];
             |     ^
          302|

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:181:25:

          180|       pythonRemoveBinBytecodeHook
          181|     ] ++ lib.optionals (lib.hasSuffix "zip" (attrs.src.name or "")) [
             |                         ^
          182|       unzip

       … while calling 'hasSuffix'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/strings.nix:284:5:

          283|     # Input string
          284|     content:
             |     ^
          285|     let

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/strings.nix:291:5:

          290|     # to strings and comparing. This was surprising and confusing.
          291|     warnIf
             |     ^
          292|       (isPath suffix)

       … while calling anonymous lambda

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/lib/trivial.nix:357:50:

          356|   */
          357|   warnIf = cond: msg: if cond then warn msg else x: x;
             |                                                  ^
          358|

       … while evaluating the attribute 'src.name'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/tools/security/frida-tools/default.nix:7:3:

            6|
            7|   src = python3.pkgs.fetchPypi {
             |   ^
            8|     inherit pname version;

       … while evaluating the attribute 'pkgs.fetchPypi'

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/development/interpreters/python/passthrufun.nix:87:5:

           86|     withPackages = import ./with-packages.nix { inherit buildEnv pythonPackages;};
           87|     pkgs = pythonPackages;
             |     ^
           88|     interpreter = "${self}/bin/${executable}";

       error: attribute 'fetchPypi' missing

       at /home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs/pkgs/tools/security/frida-tools/default.nix:7:9:

            6|
            7|   src = python3.pkgs.fetchPypi {
             |         ^
            8|     inherit pname version;
$ git worktree prune
Traceback (most recent call last):
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/cli/__init__.py", line 304, in main
    return cast(str, args.func(args))
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/cli/rev.py", line 14, in rev_command
    return review_local_revision(
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 538, in review_local_revision
    review.review_commit(builddir.path, args.branch, commit, staged, print_result)
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 291, in review_commit
    self.build_commit(branch_rev, reviewed_commit, staged),
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 153, in build_commit
    base_packages = list_packages(
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 371, in list_packages
    subprocess.run(cmd, stdout=tmp, check=True)
  File "/nix/store/95cxzy2hpizr23343b8bskl4yacf4b3l-python3-3.10.11/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['nix-env', '--extra-experimental-features', 'no-url-literals', '--option', 'system', 'x86_64-linux', '-f', '/home/user/.cache/nixpkgs-review/rev-8a64294cea1b0e5ccce96d7a08a53b6c64a598f7-1/nixpkgs', '-qaP', '--xml', '--out-path', '--show-trace', '--no-allow-import-from-derivation']' returned non-zero exit status 1.

Edit: that was quick. Fixed in #236795.

Edit: Now there is another issue:

undefined variable 'prompt_toolkit'

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs d500668a3c2f9f4f0260d742c6a0c9f146ec65f5
Preparing worktree (detached HEAD d500668a3c2)
Updating files: 100% (35563/35563), done.
HEAD is now at d500668a3c2 Merge pull request #236805 from fabaff/pyschlage-bump
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
error:
       … while querying the derivation named 'frida-tools-12.1.2'

       … while evaluating the attribute 'out.outPath'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/lib/customisation.nix:215:13:

          214|             drvPath = assert condition; drv.${outputName}.drvPath;
          215|             outPath = assert condition; drv.${outputName}.outPath;
             |             ^
          216|           } //

       … while evaluating the attribute 'propagatedBuildInputs' of the derivation 'frida-tools-12.1.2'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:303:7:

          302|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          303|       name =
             |       ^
          304|         let

       … while evaluating call site

       at «none»:0: (source not available)

       … while calling 'getOutput'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/lib/attrsets.nix:896:23:

          895|   */
          896|   getOutput = output: pkg:
             |                       ^
          897|     if ! pkg ? outputSpecified || ! pkg.outputSpecified

       … while evaluating call site

       at «none»:0: (source not available)

       … while calling anonymous lambda

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:263:13:

          262|       (map (drv: drv.__spliced.hostHost or drv) (checkDependencyList "depsHostHostPropagated" depsHostHostPropagated))
          263|       (map (drv: drv.__spliced.hostTarget or drv) (checkDependencyList "propagatedBuildInputs" propagatedBuildInputs))
             |             ^
          264|     ]

       … while evaluating call site

       at «none»:0: (source not available)

       … while calling anonymous lambda

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/lib/lists.nix:117:29:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |                             ^
          118|

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/lib/lists.nix:117:32:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |                                ^
          118|

       … while calling anonymous lambda

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:216:81:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                                                                 ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:217:8:

          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep
             |        ^
          218|     else if lib.isList dep then checkDependencyList' ([index] ++ positions) name dep

       … while calling 'isDerivation'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/lib/attrsets.nix:640:5:

          639|     # Value to check.
          640|     value: value.type or null == "derivation";
             |     ^
          641|

       … while evaluating call site

       at «none»:0: (source not available)

       … while calling 'checkDrv'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:157:16:

          156|
          157|     checkDrv = drv:
             |                ^
          158|       if (isPythonModule drv) && (isMismatchedPython drv)

       … while evaluating call site

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:158:11:

          157|     checkDrv = drv:
          158|       if (isPythonModule drv) && (isMismatchedPython drv)
             |           ^
          159|       then throwMismatch drv

       … while calling 'isPythonModule'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:112:22:

          111|   validatePythonMatches = attrName: let
          112|     isPythonModule = drv:
             |                      ^
          113|       # all pythonModules have the pythonModule attribute

       error: undefined variable 'prompt_toolkit'

       at /home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs/pkgs/tools/security/frida-tools/default.nix:14:5:

           13|     pygments
           14|     prompt_toolkit
             |     ^
           15|     colorama
$ git worktree prune
Traceback (most recent call last):
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/cli/__init__.py", line 304, in main
    return cast(str, args.func(args))
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/cli/rev.py", line 14, in rev_command
    return review_local_revision(
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 538, in review_local_revision
    review.review_commit(builddir.path, args.branch, commit, staged, print_result)
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 291, in review_commit
    self.build_commit(branch_rev, reviewed_commit, staged),
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 153, in build_commit
    base_packages = list_packages(
  File "/nix/store/cnrkkfvy93ynjk3dbmla94dx8rv21gah-nixpkgs-review-2.9.2/lib/python3.10/site-packages/nixpkgs_review/review.py", line 371, in list_packages
    subprocess.run(cmd, stdout=tmp, check=True)
  File "/nix/store/95cxzy2hpizr23343b8bskl4yacf4b3l-python3-3.10.11/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['nix-env', '--extra-experimental-features', 'no-url-literals', '--option', 'system', 'x86_64-linux', '-f', '/home/user/.cache/nixpkgs-review/rev-d500668a3c2f9f4f0260d742c6a0c9f146ec65f5/nixpkgs', '-qaP', '--xml', '--out-path', '--show-trace', '--no-allow-import-from-derivation']' returned non-zero exit status 1.

[vcunat]

prompt_toolkit fixed in PR #236828