treewide: convert remaining rust packages with git dependencies to importCargoLock#236308
Closed
raphaelr wants to merge 11 commits intoNixOS:masterfrom
Closed
treewide: convert remaining rust packages with git dependencies to importCargoLock#236308raphaelr wants to merge 11 commits intoNixOS:masterfrom
importCargoLock#236308raphaelr wants to merge 11 commits intoNixOS:masterfrom
Conversation
github-actions
Bot
added
the
6.topic: python
raphaelr
added
the
6.topic: rust
yu-re-ka
approved these changes
Jun 6, 2023
Contributor
yu-re-ka
left a comment
yu-re-ka
left a comment
There was a problem hiding this comment.
I did not realize we had missed so many. looks good 👍🏻
ofborg
Bot
added
10.rebuild-darwin: 11-100
because of git dependencies
because of git dependencies
because of git dependencies
because of git dependencies
because of git dependencies
…rgoLock because of git dependencies
because of git dependencies
because of git dependencies
because of git dependencies
because of git dependencies
because of git dependencies
Contributor
Author
|
Rebased to resolve the merge conflict |
github-actions
Bot
removed
the
6.topic: rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Followup of #221716. This PR updates some more packages with git dependencies to
importCargoLock(The only remaining package I can find is emacsPackages.tsc; I will update that in a followup PR because it requires changing an update script and thus isn't as trivial as the other packages in this PR).Currently the cargoDeps of these packages will fail to build with
ERROR: The Cargo.lock contains git dependencies. See #217084 for background information.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)