pagefind: init at 1.0.3#247773
Conversation
There was a problem hiding this comment.
I would expect overrideAttrs here
There was a problem hiding this comment.
Intuitively i would agree, but updating hashes in fetchers is a chore, and .override was enabled here: b691051
There was a problem hiding this comment.
@nixos/rust: Any one of you opposed to this? It's already in cache thanks to lldap.
Context: #89426
e6fba28 to
a463905
Compare
There was a problem hiding this comment.
(I copied this comment from the old commit before the bump to v1.0.0)
@winterqt Would you consider this pattern for building multiple npm projects sound, or should it be torched? I do not want to establish a bad precedent.
|
This forcepush bumps the version to 1.0.0. 🚀 Due to a git dependency i was force to vendor the lock, tracked in Pagefind/pagefind#421 |
a463905 to
940521c
Compare
|
This force push bumps the version to 1.0.2, removing the need to vendor the cargo lock file. I also set different names to each npm-dep, making it far easier to update their hashes. @ofborg build pagefind |
940521c to
dba7f37
Compare
|
LGTM, I have nothing to add. |
dba7f37 to
095afd8
Compare
|
I have built and run this on aarch64-darwin. It seems to work well. |
|
ofborg seems to have problems with aarch64-darwin https://logs.ofborg.org/?key=nixos/nixpkgs.247773&attempt_id=23427e33-a91f-4bc2-8ff7-dcf32dd84710 |
095afd8 to
35b7389
Compare
Description of changes
This PR packages pagefind by @CloudCannon (pagefind source), which can generate a low-bandwidth search index for nearly any static website. I've tested the use case documented here on a huge HTML soup, and it worked wonders.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)