lomiri: init basic development stuff#236282
Conversation
f121f97 to
c0df77e
Compare
25a0c7b to
5b11225
Compare
5b11225 to
e6e16bb
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2343 |
SuperSandro2000
left a comment
There was a problem hiding this comment.
not sure on the package set if it is done correct for cross
e6e16bb to
4a01040
Compare
|
I'm not sure if the package set is correctly written to support cross either, the approach was taken from the Deepin / DDE set. But most of the packages in it will use our |
We sometimes place QML modules into the bin output of derivations. Using CMAKE_INSTALL_BINDIR and backtracking from it will ensure that the modules will end up under the bin output prefix, if it is enabled.
|
@SuperSandro2000 Is the uncertainty about the package set's cross-buildability a blocker for you (and thus blocked by |
|
@SuperSandro2000 I've tried locally adding something to the package set that doesn't need Qt & building it with |
…L_PREFIX
Going `${CMAKE_INSTALL_BINDIR}/../` looks weird. Derivations that want them in a non-`out` output can just set the `QMLFILES_DESTINATION` CMake flag as needed.
Co-authored-by: rewine <luhongxu@deepin.org>
Na, I was just curious and wanted to let you know that I do not know. |
|
If we missed something especially cross related we can fix that in another PR to not delay this one any longer. |
Description of changes
Working towards #99090, in more digestible steps than last time. This one is abit bigger, but the followups can be done more or less package-by-package with all of these present.
The last 2 commits I still need to test on my system with all the Lomiri stuff, just threw them in here so those packages are less stale on arrival.Working fine, keeping them in.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)