Skip to content

lomiri.libusermetrics: init at 1.3.0#241335

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
OPNA2608:init/lomiri/libusermetrics
Jul 23, 2023
Merged

lomiri.libusermetrics: init at 1.3.0#241335
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
OPNA2608:init/lomiri/libusermetrics

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jul 3, 2023

Description of changes

Working towards #99090.

Libusermetrics, enables apps to locally store interesting numerical data for later presentation. Required by Lomiri & some of its system services & core applications.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 3, 2023
@OPNA2608 OPNA2608 force-pushed the init/lomiri/libusermetrics branch from 6521fb2 to 2710882 Compare July 5, 2023 12:22
@OPNA2608 OPNA2608 force-pushed the init/lomiri/libusermetrics branch from 2710882 to 620d11b Compare July 5, 2023 12:36
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jul 5, 2023

tst_QmlTests test always takes pretty much exactly 3 minutes to complete. Not sure if this is something intentional or some timeout, I'd like to look into this more:

Running tests...
Test project /build/source/build
    Start 1: usermetricsinput-integration-tests
    Start 2: usermetricsoutput-integration-tests
    Start 3: usermetricsinput-unit-tests
    Start 4: usermetricsoutput-unit-tests
    Start 5: usermetricsservice-unit-tests
    Start 6: tst_QmlTests
1/6 Test #1: usermetricsinput-integration-tests ....   Passed    0.04 sec
2/6 Test #2: usermetricsoutput-integration-tests ...   Passed    0.05 sec
3/6 Test #4: usermetricsoutput-unit-tests ..........   Passed    0.33 sec
4/6 Test #3: usermetricsinput-unit-tests ...........   Passed    0.37 sec
5/6 Test #5: usermetricsservice-unit-tests .........   Passed    0.59 sec
6/6 Test #6: tst_QmlTests ..........................   Passed  180.28 sec

@ofborg ofborg bot requested a review from ilyakooo0 July 5, 2023 13:24
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 5, 2023
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jul 5, 2023

Gets stuck during the teardown of the test environment. The QProcess: messages come in ~ 1 minute intervals

********* Start testing of QmlTests *********
Config: Using QtTest library 5.15.9, Qt 5.15.9 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 12.3.0), unknown unknown
PASS   : QmlTests::Increment::initTestCase()
PASS   : QmlTests::Increment::test_metric()
PASS   : QmlTests::Increment::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 26ms
********* Finished testing of QmlTests *********
QProcess: Destroyed while process ("/build/source/build/src/usermetricsservice/usermetricsservice") is still running.
QProcess: Destroyed while process ("dbus-daemon") is still running.
QProcess: Destroyed while process ("dbus-daemon") is still running.

Same thing happens in the Debian build logs. Not sure where the problem lies, but as long as it reliably resolves itself it's not really a critical problem.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/libusermetrics branch from 620d11b to c907360 Compare July 12, 2023 19:48
@OPNA2608 OPNA2608 removed the request for review from ilyakooo0 July 12, 2023 19:49
@OPNA2608 OPNA2608 marked this pull request as ready for review July 12, 2023 19:49
@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jul 12, 2023
@OPNA2608 OPNA2608 requested a review from SuperSandro2000 July 15, 2023 11:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2443

@SuperSandro2000 SuperSandro2000 merged commit a8ddb42 into NixOS:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments