Skip to content

[staging] evcxr: fix build with rust 1.70#236140

Merged
figsoda merged 1 commit intoNixOS:stagingfrom
figsoda:evcxr
Jun 7, 2023
Merged

[staging] evcxr: fix build with rust 1.70#236140
figsoda merged 1 commit intoNixOS:stagingfrom
figsoda:evcxr

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented Jun 5, 2023

Description of changes

#235438 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda mentioned this pull request Jun 5, 2023
12 tasks
@figsoda figsoda changed the title evcxr: fix build with rust 1.70 [staging] evcxr: fix build with rust 1.70 Jun 5, 2023
@ofborg ofborg bot requested review from Ma27 and protoben June 5, 2023 20:21
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 5, 2023
@trofi
Copy link
Contributor

trofi commented Jun 5, 2023

Result of nixpkgs-review pr 236140 run on x86_64-linux 1

1 package built:
  • evcxr

@figsoda figsoda merged commit 920fac7 into NixOS:staging Jun 7, 2023
@figsoda figsoda deleted the evcxr branch June 7, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants