Skip to content

rustc: 1.69.0 -> 1.70.0#235438

Merged
figsoda merged 2 commits intoNixOS:stagingfrom
figsoda:rustc
Jun 4, 2023
Merged

rustc: 1.69.0 -> 1.70.0#235438
figsoda merged 2 commits intoNixOS:stagingfrom
figsoda:rustc

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented Jun 1, 2023

https://github.com/rust-lang/rust/releases/tag/1.70.0

built fd and vector on {aarch64,x86_64}-linux on master

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested review from Mic92, winterqt and zowoq as code owners June 1, 2023 19:01
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jun 1, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 1, 2023
@zowoq
Copy link
Contributor

zowoq commented Jun 3, 2023

Can revert 9861cf4 as sparse is now the default.

sparse protocol is now the default since rust 1.70
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built passthru.tests on x86_64-darwin and firefox on x86_64-linux.

@figsoda figsoda merged commit cfb9c88 into NixOS:staging Jun 4, 2023
@figsoda figsoda deleted the rustc branch June 4, 2023 19:06
@trofi
Copy link
Contributor

trofi commented Jun 5, 2023

Bisect claims that ff16966 rustc: 1.69.0 -> 1.70.0 broke evcxr in staging:

$ nix build --no-link -f. -L evcxr
...
evcxr> failures:
evcxr> ---- partially_inferred_variable_type stdout ----
evcxr> ======== last src ========
evcxr> #![allow(unused_imports, unused_mut, dead_code)]
evcxr>             struct EvcxrUserCodeError {}
evcxr>             impl<T: std::fmt::Display> From<T> for EvcxrUserCodeError {
evcxr>                 fn from(error: T) -> Self {
evcxr>                     eprintln!("{}", error);
evcxr>                     EvcxrUserCodeError {}
evcxr>                 }
evcxr>             }
evcxr> fn evcxr_variable_store<T: 'static>(_: T) {}
evcxr> #[allow(unused_variables)]
evcxr> async fn evcxr_analysis_wrapper(
evcxr> ) -> Result<(), EvcxrUserCodeError> {
evcxr> let v : Vec < _ > = (1 .. 10).collect() ;
evcxr> evcxr_variable_store(v);
evcxr> Ok(())
evcxr> }
evcxr> ==========================
evcxr> Couldn't automatically determine type of variable `v`.
evcxr> Please give it an explicit type.
evcxr> thread 'partially_inferred_variable_type' panicked at 'Unexpected compilation error. See above for details', evcxr/tests/integration_tests.rs:677:5
evcxr> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
evcxr> failures:
evcxr>     partially_inferred_variable_type
evcxr> test result: FAILED. 35 passed; 1 failed; 0 ignored; 0 measured; 1 filtered out; finished in 42.87s

@figsoda
Copy link
Member Author

figsoda commented Jun 5, 2023

#236140

rust_1_69 = callPackage ../development/compilers/rust/1_69.nix {
rust_1_70 = callPackage ../development/compilers/rust/1_70.nix {
inherit (darwin.apple_sdk.frameworks) CoreFoundation Security SystemConfiguration;
llvm_15 = llvmPackages_15.libllvm;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llvm should be updated to 16, see https://github.com/rust-lang/rust/releases/tag/1.70.0 (internal changes)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants