Merged
Conversation
github-actions
bot
added
the
6.topic: python
kalekseev
force-pushed
the
update/playwright
branch
from
44ff124 to
82f8be7
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
12 tasks
| @@ -2,7 +2,7 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
We should stop using node2nix if possible
Member
There was a problem hiding this comment.
is buildNpmPackage the encouraged function then ? I had trouble for some packages where node2nix succeeded (possibly playwright but I dont remember).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed playwright update script to work with changes introduced in #223382
Updated playwright to latest version
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)