Skip to content

playwright: 1.32.1 -> 1.34.0#230111

Closed
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/playwright
Closed

playwright: 1.32.1 -> 1.34.0#230111
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/playwright

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 5, 2023

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/playwright-python/releases.

meta.description for playwright is: Python version of the Playwright testing and automation library

meta.homepage for playwright is: https://github.com/microsoft/playwright-python

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.33.0 with grep in /nix/store/7nl25g3vqr03v3ss0z6v4l75rk4jyhb8-python3.10-playwright-1.33.0
  • found 1.33.0 in filename of file in /nix/store/7nl25g3vqr03v3ss0z6v4l75rk4jyhb8-python3.10-playwright-1.33.0

Rebuild report (if merged into master) (click to expand)
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
changedetection-io
playwright
python310Packages.playwright
python310Packages.pytest-playwright
python311Packages.playwright
python311Packages.pytest-playwright
shot-scraper
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/7nl25g3vqr03v3ss0z6v4l75rk4jyhb8-python3.10-playwright-1.33.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A playwright https://github.com/r-ryantm/nixpkgs/archive/981344d0650db4ded475c58632c74810eea54a9b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/7nl25g3vqr03v3ss0z6v4l75rk4jyhb8-python3.10-playwright-1.33.0
ls -la /nix/store/7nl25g3vqr03v3ss0z6v4l75rk4jyhb8-python3.10-playwright-1.33.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

6 packages built:
  • changedetection-io
  • playwright (python310Packages.playwright)
  • python310Packages.pytest-playwright
  • python311Packages.playwright
  • python311Packages.pytest-playwright
  • shot-scraper

Maintainer pings

cc @techknowlogick @yrd @SuperSandro2000 for testing.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 5, 2023
@ofborg ofborg bot requested review from SuperSandro2000, techknowlogick and yrd May 5, 2023 13:13
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 5, 2023
@teto
Copy link
Member

teto commented May 5, 2023

plawyright updates should update playwright-driver as well since the path to browser contains the version number. Not sure how to enforce that (assert/tests). If playwright-driver is updated, playwright-test must be as well. Probaly need an updater script ?

@wegank wegank marked this pull request as draft May 9, 2023 11:02
@r-ryantm r-ryantm force-pushed the auto-update/playwright branch from 981344d to 3a40343 Compare May 31, 2023 23:06
@r-ryantm r-ryantm changed the title playwright: 1.32.1 -> 1.33.0 playwright: 1.32.1 -> 1.34.0 Jun 1, 2023
@r-ryantm
Copy link
Contributor Author

r-ryantm commented Jun 1, 2023

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/playwright-python/releases.

meta.description for playwright is: Python version of the Playwright testing and automation library

meta.homepage for playwright is: https://github.com/microsoft/playwright-python

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.34.0 with grep in /nix/store/4gamabdr0282fqi28bpas7dmxzci0mv3-python3.10-playwright-1.34.0
  • found 1.34.0 in filename of file in /nix/store/4gamabdr0282fqi28bpas7dmxzci0mv3-python3.10-playwright-1.34.0

Rebuild report (if merged into master) (click to expand)
7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
changedetection-io
playwright
python310Packages.playwright
python310Packages.pytest-playwright
python311Packages.playwright
python311Packages.pytest-playwright
shot-scraper
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4gamabdr0282fqi28bpas7dmxzci0mv3-python3.10-playwright-1.34.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A playwright https://github.com/r-ryantm/nixpkgs/archive/3a40343235889f06c9392c62a0ccfda47e9d6d5f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4gamabdr0282fqi28bpas7dmxzci0mv3-python3.10-playwright-1.34.0
ls -la /nix/store/4gamabdr0282fqi28bpas7dmxzci0mv3-python3.10-playwright-1.34.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out


Maintainer pings

cc @techknowlogick @yrd @SuperSandro2000 for testing.

@kalekseev
Copy link
Contributor

@teto what about inherit (playwright-driver) version;?

@kalekseev
Copy link
Contributor

@teto what about inherit (playwright-driver) version;?

well, they don't match on patch version:

@kalekseev
Copy link
Contributor

@teto apparently playwright had an update script, fixed it in #235914

@kalekseev kalekseev closed this Jun 4, 2023
@r-ryantm r-ryantm deleted the auto-update/playwright branch June 4, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants