Skip to content

python3.pkgs.fetchPypi: deprecate in favor of top-level fetchPypi#234043

Merged
wegank merged 1 commit intoNixOS:masterfrom
figsoda:pypi
Jun 1, 2023
Merged

python3.pkgs.fetchPypi: deprecate in favor of top-level fetchPypi#234043
wegank merged 1 commit intoNixOS:masterfrom
figsoda:pypi

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented May 25, 2023 •
edited
Loading

Description of changes

closes #233252

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested a review from FRidh as a code owner May 25, 2023 18:45
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 25, 2023
@figsoda figsoda marked this pull request as draft May 25, 2023 18:45
@figsoda figsoda requested review from jonringer and mweinelt May 25, 2023 18:46
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels May 25, 2023
wegank
wegank reviewed May 25, 2023
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 25, 2023
@figsoda figsoda marked this pull request as ready for review May 25, 2023 19:46
@figsoda
Copy link
Member Author

figsoda commented May 28, 2023

fixed merge conflicts

SuperSandro2000
SuperSandro2000 reviewed May 31, 2023
View reviewed changes
@wegank wegank merged commit 076e3d5 into NixOS:master Jun 1, 2023
@figsoda figsoda deleted the pypi branch June 1, 2023 17:56
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jun 8, 2023
Closed
6 tasks
@tobim tobim mentioned this pull request Jun 9, 2023
Merged
12 tasks
panicgh added a commit to panicgh/nixpkgs that referenced this pull request Jun 9, 2023
@panicgh
ical2orgpy: use top-level fetchPypi
f8f0d91 
python3.pkgs.fetchPypi was deprecated in favor of top-level fetchPypi,
see NixOS#234043.
@panicgh panicgh mentioned this pull request Jun 9, 2023
Closed
12 tasks
@Dessix Dessix mentioned this pull request Jun 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@wegank wegank wegank approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@mweinelt mweinelt Awaiting requested review from mweinelt

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove usages of non-toplevel fetchPypi

4 participants

@figsoda @FRidh @SuperSandro2000 @wegank