writers.writeNginxConfig: use crossplane to test the output

[RossComputerGuy]

Description of changes

Modifies writers.writeNginxConfig to use nginx -t as gixy doesn't check everything.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[lilyinstarlight]

@ofborg build nixosTests.nginx nixosTests.nginx-auth nixosTests.nginx-etag nixosTests.nginx-globalredirect nixosTests.nginx-http3 nixosTests.nginx-modsecurity nixosTests.nginx-njs nixosTests.nginx-pubhtml nixosTests.nginx-sandbox nixosTests.nginx-sso nixosTests.nginx-variants

[Lassulus]

error: builder for '/nix/store/5zjmqwpgc047byc9zmpvrkgi960clhm6-nginx.conf.drv' failed with exit code 5;
       last 10 log lines:
       >
       > ==================== Summary ===================
       > Total issues:
       >     Unspecified: 0
       >     Low: 0
       >     Medium: 0
       >     High: 0
       >
       > invalid number of arguments in "proxy_pass" directive in /nix/store/h007vhip0yxyp05mh34grsakz6y8dd2m-nginx.conf:44
       > "server" directive is not allowed here in /nix/store/h007vhip0yxyp05mh34grsakz6y8dd2m-nginx.conf:47
``` when I try to run the nginx test.

[ajs124]

Can you also adjust the title and commit message.

I thought this was probably something similar to #205561 (and #207532), which was reverted.

[RossComputerGuy]

Can you also adjust the title and commit message.

Done

invalid number of arguments in "proxy_pass" directive in /nix/store/h007vhip0yxyp05mh34grsakz6y8dd2m-nginx.conf:44

I'll take a look at this, where's the test defined?

[RossComputerGuy]

I see that the line where the error occurs at is:

proxy_pass ;;;;

I looked at the documentation for the proxy module's proxy_pass command and it looks like it requires an argument so we just need to change it.

[lilyinstarlight]

I see that the line where the error occurs at is:

proxy_pass ;;;;

I looked at the documentation for the proxy module's proxy_pass command and it looks like it requires an argument so we just need to change it.

It looks like that is a test that is intentionally supposed to fail at runtime (in specialisation.reloadWithErrorsSystem.configuration)

Perhaps we just need to add an escape hatch to turn off syntax checking, or we could make that test use something that isn't a syntax error but still fails nginx -t (e.g. including a non-existent file)

[RossComputerGuy]

I don't care about this anymore