Skip to content

nixos/nginx: disable configuration validation for now#207532

Merged
symphorien merged 1 commit intoNixOS:masterfrom
Mic92:nginx-fix
Dec 24, 2022
Merged

nixos/nginx: disable configuration validation for now#207532
symphorien merged 1 commit intoNixOS:masterfrom
Mic92:nginx-fix

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 24, 2022

There still seem a lot of breakages not addressed yet:

#205561

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mic92
nixos/nginx: disable configuration validation for now
7ef58bc 
There still seem a lot of breakages not addressed yet:

NixOS#205561
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 24, 2022
@Mic92 Mic92 mentioned this pull request Dec 24, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2022
@symphorien symphorien merged commit 8abfd56 into NixOS:master Dec 24, 2022
@Mic92 Mic92 deleted the nginx-fix branch December 25, 2022 23:15
@symphorien symphorien mentioned this pull request Jan 4, 2023
Merged
13 tasks
@ajs124 ajs124 mentioned this pull request Mar 3, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mic92 @RaitoBezarius @symphorien