magma: init 2.7.1; migrate to cudaPackages#217410
Merged
samuela merged 1 commit intoNixOS:masterfrom Feb 27, 2023
Merged
Conversation
github-actions
bot
added
the
6.topic: python
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
e9fe740 to
abedeae
Compare
Contributor
Author
|
Result of 2 packages failed to build:
2 packages built:
|
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
3 times, most recently
from
f60a65f to
f79dcdf
Compare
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
2 times, most recently
from
bb7b6ce to
1f1ed0b
Compare
Contributor
Author
|
Result of 5 packages built:
|
Contributor
Author
|
cc @NixOS/cuda-maintainers |
19 tasks
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
1f1ed0b to
812324f
Compare
ConnorBaker
changed the title
Contributor
Author
|
Rebased and now introducing 2.7.1. Builds just fine on CUDA. 2.7.1, like 2.7.0, fails on ROCm -- and in the same way, when linking. 2.6.2 remains the default for ROCm. |
Contributor
Author
|
Will rewrite releases.json in nix later tonight, time permitting. |
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
812324f to
277b772
Compare
Contributor
Author
|
Now with 50% more Nix! |
samuela
reviewed
Feb 24, 2023
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
277b772 to
0918023
Compare
Contributor
Author
|
Running |
Contributor
Author
|
Result of 5 packages built:
|
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
0918023 to
e5f4d72
Compare
Contributor
Author
|
And again after rebasing on master |
ConnorBaker
force-pushed
the
feat/magma-2.7.0
branch
from
e5f4d72 to
434c3ea
Compare
Contributor
Author
|
Result of 5 packages built:
|
Contributor
Author
|
Wahoo no failures! |
ConnorBaker
requested review from
samuela
and removed request for
FRidh,
jonringer,
tbenst,
teh,
thoughtpolice and
tscholak
Member
|
Result of 5 packages built:
|
Member
|
LGTM thanks @ConnorBaker ! |
12 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds magma 2.7.1 and makes it the default.
AMD's HIP doesn't work on anything newer than 2.6.2 -- something causes a failure when trying to link
libmagma.so-- so 2.6.2 remains the default formagma-hip.Note that this PR includes a move to using a
releases.json. This is done mostly to remove boilerplate from the Nix derivation and avoid clutter fromsupportedGpuTargets.I've run into this problem elsewhere, but it's important that packages which target specific GPU architectures are aware of the architectures they support. The architectures available to this package via
hip.gpuTargets,cudaFlags.cudaRealArchs, and thegpuTargetsargument can cause frustrating build failures if they are not sanitized. Unfortunately, in this case that meant looking at Magma's CMakeLists.txt to find out which architectures are supported. For both CUDA and ROCm, I decided to use the SM and GFX names respectively, because Magma allows more granular support than when building for entire generations.Following in the footsteps of @SomeoneSerge's work (#168745), migrate to
cudaPackages.Updated torch to reference the new
passthruattributecudaPackagesinstead ofcudatoolkit.Closure before:
/nix/store/mcl5f361f3zix9bymp7rx9xcml0b2g4y-magma-2.6.2 518.6M 5.4GDetails
Closure after (for a previous version of this PR targeting 2.7.0; the size different is still as large):
/nix/store/jb024nl0mvvrrsxw06ha1s96wsx69993-magma-2.7.0 389.5M 2.3GDetails
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Failures
The below is kept for posterity; it was my attempt at troubleshooting AMD support prior to deciding to keep a copy of 2.6.2.
Details
Linking CXX shared library lib/libmagma.so.And so we do a rough binary search through the commit history of Magma to find out when it broke :(
EDIT: What a headache. I'll split the package so CUDA gets 2.7.0 and HIP can stay on 2.6.2.
2023-02-10revert api changes for the batch gemv routines that accept pointer arrays: https://bitbucket.org/icl/magma/commits/1814c2518a76b81d75e5987d35797305ef2c9f4d.2022-10-28update release note: https://bitbucket.org/icl/magma/commits/e96d4c97be78a8b19b273dbaa99955d6529e539a.2022-10-17bug fix: https://bitbucket.org/icl/magma/src/001df2f69f8c25f4e722a6ff997a2aa69da0d4e0.2022-10-11unnecessary includes: https://bitbucket.org/icl/magma/commits/e8a673d27c7e927ec8eda0c2059b7a213baa6e4e.2022-06-26update notes for next release: https://bitbucket.org/icl/magma/src/24410113e61fc72c2cbc039c2cef9aa7dc815a92.2022-06-24allow launch bounds for CUDA: https://bitbucket.org/icl/magma/src/849bf8e00e929da7699a02424466e127a883668f.2022-06-23Merged in master (pull request#21): https://bitbucket.org/icl/magma/src/9e0b130afaf3fe635441cba351555505c9d68e28.Makefile:357: magmablas_hip/Makefile.src: No such file or directory.2022-05-24call the new gemm prototype with version 2: https://bitbucket.org/icl/magma/src/ec35ab142120a1a067f1a77f5392b70f5367e8a9.2022-05-24minor: https://bitbucket.org/icl/magma/src/5eec59630f963a46bff59cbab6f39610fc9c610b.2022-04-20potential fix for failures at very large matrix sizes: https://bitbucket.org/icl/magma/commits/d998fcbb94d9046ec98ae93757010a1472902d54.