magma: fix #220343 and separate CUDA build/run-time dependencies#220366
Conversation
d8b393e to
37c8d5f
Compare
|
@NixOS/cuda-maintainers |
37c8d5f to
c5c6b76
Compare
b8041ce to
ebd45bb
Compare
|
@SomeoneSerge I just understood what you meant now when you asked whether setting Build fines without it, too: no more errors when trying to detect the CUDA version during CMake's configurePhase. |
ebd45bb to
c4905c0
Compare
c4905c0 to
2b47a7a
Compare
|
@tbenst this should be fully ready for you to review now, sorry about the delay! |
2b47a7a to
0cf4ddd
Compare
|
Result of 11 packages built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1 |
|
cc @tbenst friendly ping as maintainer |
Nice work on this! I’m hoping to finish my PhD soon(TM) and had to step away from Nix in favor of productivity so I’m not in a position to review / maintain right now. Sorry about that! Please feel free to remove me as a maintainer. |
c312bd2 to
dcbb5ed
Compare
samuela
left a comment
There was a problem hiding this comment.
LGTM! @SomeoneSerge does this look ok to you?
No problem, @tbenst . Best of luck with your defense! |
|
Result of 11 packages built:
|
|
Great, thanks so much @ConnorBaker and @SomeoneSerge ! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-46/26872/1 |
Description of changes
Goal is to shrink the size of the closure, or modularize the components which are downloaded.
Also fixes #220343.
My hope is that, for packages which do not fully support CUDA redistributables, by creating separate symlinked copies of what cudatoolkit would provide we can improve the user experience.
Closure before:
Closure after:
Details
Common derivations:
Derivations unique to before:
Derivations unique to after:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)