texinfo: 6.8 -> 7.0.2

[afh]

Change default texinfo to 7

Description of changes

Add package for texinfo 7.0.2 and make it the default.

Please chime in if you believe changing the default texinfo to 7.0.2 is too drastic of a change or should be communicated elsewhere than just the release notes.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[afh]

Here is a new PR as requested by @winterqt (for context see #215654). Do you have any idea of what may have gone wrong with a review having been requested from so many folks?

[ncfavier]

I'm guessing you did not follow the instructions for rebasing smoothly.

As for the patch thing, the build log shows that some script is failing due to /usr/bin/env not being present in the sandbox. patchShebangs replaces /usr/bin/env shebangs with a direct call to the requested interpreter (in this case Perl).

[afh]

Thanks for the explanation @ncfavier. I was not aware about the special procedure that is necessary when rebasing. I apologies for the unnecessary pings to people and disruption of their time and attention this has likely created. Mea culpa 😞

[trofi]

LGTM with a minor nit.

My naive grep says texinfo might be directly used by a few packages. I'll try a local build on them and complain back if something fails.

List I found: R allegro5 asdf asdf_2_26 asdf_3_1 asymptote autoconf autoconf271 bashInteractive bashInteractiveFHS bashInteractive_5 bc binutils-unwrapped_2_38 blitz cgdb cgui chrony cmakeCurses cmakeWithGui cre2 docbook2x e2fsprogs ecl emacs emacs-gtk emacs-nox emacs28 emacs28-gtk emacs28-nox emacs28NativeComp emacsNativeComp ffmpeg ffmpeg-full ffmpeg-headless ffmpeg_4 ffmpeg_4-full ffmpeg_4-headless ffmpeg_5 ffmpeg_5-full ffmpeg_5-headless flex_2_5_35 foxtrotgps freetalk frr fswatch fuse2fs gama gauche gaucheBootstrap gcl gcl_2_6_13_pre gdb gengetopt gforth git git-doc gitFull gitSVN glibcInfo gnu-cobol gnupg gnupg24 gnuplot gnuplot_aquaterm gnuplot_qt gpgme groff guile-config guile-fibers guile-gcrypt guile-git guile-hall guile-json guile-lib guile-sqlite3 guile-ssh guile-xcb gxmessage heimdal idutils indent irods irods-icommands jellyfin-ffmpeg jffi ledger lepton-eda libheimdal liblouis libmikmod libredwg librep libtasn1 lilypond lilypond-unstable linuxdoc-tools lzlib macchanger mailutils marst maxima maxima-ecl mercury mitscheme mitschemeX11 monotone mpfi nano ne netmask notmuch ocrad octave octaveFull pinentry-rofi pinfo plzip poke ponysay proxysql pspp qemu qemu_full qemu_kvm qemu_test quickjs recode rocgdb rubber sawfish sbcl sbcl_2_0_8 sbcl_2_0_9 sbcl_2_1_1 sbcl_2_1_10 sbcl_2_1_11 sbcl_2_1_2 sbcl_2_1_9 sbcl_2_2_10 sbcl_2_2_11 sbcl_2_2_4 sbcl_2_2_6 sbcl_2_2_9 sbcl_2_3_0 sdcc sgx-sdk solfege speechd tahoe-lafs taler-exchange taler-merchant tangogps tarlz tinc_pre tinycc udunits wdiff wget2 wipefreespace wsjtx xboard xnee xprintidle-ng xzgv zsh

[AndersonTorres]

Fix the message of the commit: postPath -> postPatch

[trofi]

At least texinfoInteractive fails to build as:

XPASS: test_scripts/layout_formatting_fr_icons.sh
PASS: test_scripts/layout_formatting_epub.sh
PASS: test_scripts/layout_formatting.sh
PASS: test_scripts/layout_formatting_epub_nodes.sh
============================================================================
Testsuite summary for GNU Texinfo 7.0.2
============================================================================
# TOTAL: 144
# PASS:  112
# SKIP:  31
# XFAIL: 0
# FAIL:  0
# XPASS: 1
# ERROR: 0
============================================================================
See tp/tests/test-suite.log
Please report to [email protected]
============================================================================

AFAIU XPASS failure is unexpected.

[afh]

@trofi I was able to build texinfoInteractive using nix shell nixpkgs-dev#texinfoInteractive. Which command(s) did you use to build texinfoInteractive that failed as you described?

[trofi]

@trofi I was able to build texinfoInteractive using nix shell nixpkgs-dev#texinfoInteractive. Which command(s) did you use to build texinfoInteractive that failed as you described?

it's an x86_64-linux system. Otherwise it should be equivalent to your's. I did it as:

$ nix build github:NixOS/nixpkgs/pull/215699/merge#texinfoInteractive
...
error: builder for '/nix/store/g8cvcfblamsd2b9cizrlmiv9q0ajxc2c-texinfo-interactive-7.0.2.drv' failed with exit code 2;

Maybe it's a locale-dependent failure.

[ncfavier]

We just need to condition

nixpkgs/pkgs/development/tools/misc/texinfo/common.nix

Lines 61 to 65 in e5530ab

	checkFlags = lib.optionals (!stdenv.hostPlatform.isMusl) [
	# Test is known to fail on various locales on texinfo-6.8:
	# https://lists.gnu.org/r/bug-texinfo/2021-07/msg00012.html
	"XFAIL_TESTS=test_scripts/layout_formatting_fr_icons.sh"
	];

on version < 7.

[afh]

@trofi mind retrying the texinfoInteractive build now that the suggestion from @ncfavier has been pushed to this PR?

[trofi]

@trofi mind retrying the texinfoInteractive build now that the suggestion from @ncfavier has been pushed to this PR?

Yup, that did it. Thank you!

[AndersonTorres]

Except maybe by release note, LGTM.

[afh]

Thanks everyone for your review, helpful comments, and suggestions, very much appreciated, especially as I learned a few new things about nixpkgs.

From my end this PR is good to be merged, if anyone with the necessary permissions agrees please do so at your latest convenience 🙂

[AndersonTorres]

@ofborg build

[AndersonTorres]

Should I we ignore Darwin failure?

[winterqt]

@AndersonTorres @ofborg build doesn't do anything without arguments. You need @ofborg eval, which you did in a deleted comment.

[winterqt]

Should I we ignore Darwin failure?

error: building of '/nix/store/64gbskxarzv0nm4zbv7ijhhfiqkvb47j-llvm-11.1.0.drv!lib,out' from .drv file timed out after 3600 seconds

Timed out as expected, but I can test on master.

[AndersonTorres]

@AndersonTorres @ofborg build doesn't do anything without arguments. You need @ofborg eval, which you did in a deleted comment.

I believed it was just the opposite, eval needs args but build doesn't...

[afh]

Just checking in on the status here… Anything that is needed from me or needs to be resolved before this can get merged?

[trofi]

I did not fine any regression so far. Should be fine to merge. Worst case we'll pin back the previous version of texinfo for those packages that end up failing to build.

[afh]

Thanks everyone for all the helpful input to get this merged, very much appreciated 🙌
Happy to help out and do some legwork if something related to texinfo7 now being the default breaks.