Skip to content

Conversation

@afh
Copy link
Member

@afh afh commented Feb 10, 2023

Change default texinfo to 7

Description of changes

Add package for texinfo 7.0.2 and make it the default.

Please chime in if you believe changing the default texinfo to 7.0.2 is too drastic of a change or should be communicated elsewhere than just the release notes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@afh afh requested review from alyssais and ncfavier and removed request for alyssais and ncfavier February 10, 2023 08:45
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes labels Feb 10, 2023
@afh afh requested a review from AndersonTorres February 10, 2023 08:45
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Feb 10, 2023
@afh afh requested a review from alyssais February 10, 2023 08:45
@AndersonTorres
Copy link
Member

Why is this broken?

@ncfavier
Copy link
Member

Needs

postPatch = ''
  patchShebangs tp/maintain
'';

Also please rebase on staging.

@afh afh requested a review from infinisil as a code owner February 10, 2023 17:03
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: vim Advanced text editor labels Feb 10, 2023
@afh afh changed the base branch from master to staging February 10, 2023 17:04
@github-actions github-actions bot removed 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: kernel The Linux kernel 6.topic: vim Advanced text editor labels Feb 10, 2023
Change default texinfo to 7
@afh
Copy link
Member Author

afh commented Feb 10, 2023

I'm not sure for GitHub things I have requested review from so many folks, I certainly did not do so on purpose. Apologies if you have pinged accidentally.

Thanks for chiming in, @ncfavier. Can you elaborate a bit on why the postPatch phase is necessary and where I find more information about?

@winterqt
Copy link
Member

Please reopen this, we can't unsubscribe people from notifications like that.

@winterqt winterqt closed this Feb 10, 2023
@NixOS NixOS locked and limited conversation to collaborators Feb 10, 2023
@afh afh deleted the texinfo7 branch February 10, 2023 17:17
@afh afh restored the texinfo7 branch February 10, 2023 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants