mariadb: fix musl, make Numa optional; pmdk: remove#214981
mariadb: fix musl, make Numa optional; pmdk: remove#214981ajs124 merged 2 commits intoNixOS:stagingfrom superherointj:fix-musl-mariadb
Conversation
superherointj
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
superherointj
removed
the
6.topic: haskell
superherointj
requested review from
SuperSandro2000
and removed request for
cdepillabout,
maralorn and
sternenseemann
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 0
You could probably put it into the release notes? Idk if it's really worth mentioning though. |
No further support or maintenance planned by upstream. https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/ Alpine also removed pmdk package: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/43663
github-actions
bot
removed
the
6.topic: haskell
|
Do we have something like "notability guidelines" for the release notes? Something like "MariaDB is built without NUMA support by default now" is IMO enough, because people that would be affected by it understand it, but then again, I don't think "bloated" release notes that nobody reads through are useful, either. Also, the people that this matters to, if they even exist, probably have monitoring and metrics in place that would alert them, if this actually negatively impacted performance for them. |
|
@ajs124 Can I merge this as it is? |
|
Yeah, should be fine. I ran nixpkgs review and a bunch of things (e.g. amarok) failed to build, but they all seem unrelated. Edit: and ofborg is unhappy, because of some python thing the testrunner depends on. great. |
| propagatedBuildInputs = lib.optionals withEmbedded | ||
| (lib.optional (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isx86_64) pmdk.lib | ||
| ++ lib.optional (stdenv.hostPlatform.isLinux && !stdenv.hostPlatform.isAarch32) numactl); | ||
| (lib.optional withNuma numactl); |
There was a problem hiding this comment.
The conditions could have been combined here IIUTC
There was a problem hiding this comment.
Yes, and I actually think this can be removed because it is deprecated:
https://dev.mysql.com/doc/refman/5.7/en/source-configuration-options.html#option_cmake_with_embedded_server
NUMA still makes sense though.
4 participants
MariaDB:
It's only used by large servers. Most users don't have hardware that require Numa. Whoever needs it can use from the flag. Should it be documented? Where (specifically)?
pmdk: remove
https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/43663
References:
Cherry-pick is merged to Haskell: