Skip to content

haskellPackages.hslua-core: skip tests for Musl#214942

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
superherointj:fix-pkgsMusl.haskellPackages.hslua-core
Feb 7, 2023
Merged

haskellPackages.hslua-core: skip tests for Musl#214942
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
superherointj:fix-pkgsMusl.haskellPackages.hslua-core

Conversation

@superherointj
Copy link
Contributor

@superherointj superherointj commented Feb 6, 2023 •
edited
Loading

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 6, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 6, 2023
@superherointj superherointj mentioned this pull request Feb 6, 2023
Merged
@superherointj superherointj added the 6.topic: musl Running or building packages with musl libc label Feb 6, 2023
@cdepillabout
Copy link
Member

cdepillabout commented Feb 7, 2023

Could you rebase on the haskell-updates branch? We generally ask that all haskell-related PRs go to that branch.

@superherointj superherointj changed the base branch from master to haskell-updates February 7, 2023 01:15
@superherointj
Copy link
Contributor Author

superherointj commented Feb 7, 2023

Could you rebase on the haskell-updates branch? We generally ask that all haskell-related PRs go to that branch.

Thanks for the feedback. I'm not really used to making PRs for Haskell. This is my first. I hope it is well now.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 7, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 7, 2023
@cdepillabout
Copy link
Member

cdepillabout commented Feb 7, 2023

Thanks!

I've confirmed that with this change, now pkgsMusl.haskellPackages.hslua is able to be compiled again.

This should be available on master when #213089 is merged in.

@cdepillabout cdepillabout merged commit 27f7c8a into NixOS:haskell-updates Feb 7, 2023
@superherointj superherointj deleted the fix-pkgsMusl.haskellPackages.hslua-core branch February 7, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: musl Running or building packages with musl libc 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pkgsMusl.haskellPackages.hslua-core: build fails

2 participants

@superherointj @cdepillabout

Comments