Skip to content

fennel-language-server: init at 2022-10-26#209173

Closed
Kaisia-Estrel wants to merge 2 commits intoNixOS:masterfrom
Kaisia-Estrel:fennel-language-server
Closed

fennel-language-server: init at 2022-10-26#209173
Kaisia-Estrel wants to merge 2 commits intoNixOS:masterfrom
Kaisia-Estrel:fennel-language-server

Conversation

@Kaisia-Estrel
Copy link

@Kaisia-Estrel Kaisia-Estrel commented Jan 5, 2023

Description of changes

Language Server for Fennel (https://github.com/rydesun/fennel-language-server)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 5, 2023
@Kaisia-Estrel Kaisia-Estrel closed this by deleting the head repository Jan 17, 2023
@Kaisia-Estrel Kaisia-Estrel reopened this Jan 19, 2023
@emm312
Copy link

emm312 commented Jan 30, 2023

merge when

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2025
@KAction
Copy link
Contributor

KAction commented Jan 19, 2026

(I don't have the commit bit)

Is there a reason to prefer https://github.com/rydesun/fennel-language-server (last updated years ago) over https://git.sr.ht/~xerool/fennel-ls (last updated weeks ago)?

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 19, 2026
@teto
Copy link
Member

teto commented Jan 19, 2026

(for what it's worth, nvim-lspconfig seems to support both)

@emilazy
Copy link
Member

emilazy commented Feb 16, 2026

This pull request behaves deeply anomalously: the repository is deleted, which normally force‐closes a pull request, and yet it has been reopened somehow anyway. The mergeability check seems to spin endlessly and CI is not running, so there is no way to merge it. (FWIW, it would not pass CI due to e.g. the enforcement of tree‐wide formatting since this PR was opened.)

As this PR cannot be merged, it should probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants