wallgen: init at unstable-2021-02-21

[j0hax]

Motivation for this change

Package a Python application to generate wallpapers (demo)

I should add that as this Project doesn't have specific versioning, I opted to use short commit hashes. If there are preffered ways instead, LMK.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[IvarWithoutBones]

Thank you for the contribution! I left a few comments, but otherwise LGTM :)

[IvarWithoutBones]

Suggested change

	wallgen = callPackage ../applications/misc/wallgen { };
	wallgen = pythonPackages.callPackage ../applications/misc/wallgen { };

[j0hax]

I also changed pythonPackages.callPackage to python3Packages.callPackage

[IvarWithoutBones]

Suggested change

	with import <nixpkgs> { };
	with pkgs.python3Packages;
	{ lib, buildPythonPackage, fetchFromGitHub, pillow, click, cython, scipy, flask, gevent, numpy, scikitimage, loguru }:

[IvarWithoutBones]

See https://nixos.org/manual/nixpkgs/stable/#sec-package-naming:
If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

[IvarWithoutBones]

Suggested change

	pname = "wallgen";
	version = "wallgen-unstable-2021-02-21";
	pname = "wallgen";
	version = "unstable-2021-02-21";

[IvarWithoutBones]

Oops, my suggestion was not quite right.

Suggested change

	{ lib, buildPythonPackage, fetchFromGitHub, pillow, click, cython, scipy, flask, gevent, numpy, scikitimage, loguru }:
	{ lib, buildPythonApplication, fetchFromGitHub, pillow, click, cython, scipy, flask, gevent, numpy, scikitimage, loguru }:

[j0hax]

Thank you for the pointers!

[IvarWithoutBones]

For consistency's sake, the whitespace here should be removed.

Suggested change

	buildPythonApplication rec {
	pname = "wallgen";
	buildPythonApplication rec {
	pname = "wallgen";

[IvarWithoutBones]

Result of nixpkgs-review pr 120340 run on x86_64-linux 1

1 package built:

• wallgen

[j0hax]

The package itself builds fine, but I am getting following error after installing:

$ wallgen
Traceback (most recent call last):
  File "/nix/store/nq1aa9a5ql0zahgfdkx435na3vnglz0q-wallgen-unstable-2021-02-21/bin/.wallgen-wrapped", line 6, in <module>
    from wallgen import cli
ModuleNotFoundError: No module named 'wallgen'

I will have to investigate if this issue comes from upstream, persists on other configurations/distributions, and possibly write a patch.

For now I would think it's good to draft the PR.

Somebody more experienced than me with packaging Python for Nix might want to take a look at the official installation instructions.

[stale]

I marked this as stale due to inactivity. → More info

[emilazy]

Closing due to being unmergeable as the fork repository is gone; see #209173 (comment).