-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
androidenv: Support deploying multiple packages in one derivation #208380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Artturin
merged 4 commits into
NixOS:master
from
hadilq:androidenv/support-deplying-multiple-packages-in-one-derivation
Jan 11, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bceccb7
androidenv: Replace deploy-androidpackage.nix with deploy-androidpack…
hadilq d1a1f2f
androidenv: Fix we are using 2 spaces to intend nix code in
hadilq 2f06ede
Update pkgs/development/mobile/androidenv/deploy-androidpackages.nix
hadilq 8ca4470
androidenv: use unzip in nativeBuildInputs
hadilq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 0 additions & 46 deletions
46
pkgs/development/mobile/androidenv/deploy-androidpackage.nix
This file was deleted.
Oops, something went wrong.
57 changes: 57 additions & 0 deletions
57
pkgs/development/mobile/androidenv/deploy-androidpackages.nix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| {stdenv, lib, unzip, mkLicenses}: | ||
| {packages, os ? null, nativeBuildInputs ? [], buildInputs ? [], patchesInstructions ? {}, meta ? {}, ...}@args: | ||
|
|
||
| let | ||
| extraParams = removeAttrs args [ "packages" "os" "buildInputs" "nativeBuildInputs" "patchesInstructions" ]; | ||
| sortedPackages = builtins.sort (x: y: builtins.lessThan x.name y.name) packages; | ||
| in | ||
| stdenv.mkDerivation ({ | ||
| inherit buildInputs; | ||
| pname = lib.concatMapStringsSep "-" (package: package.name) sortedPackages; | ||
| version = lib.concatMapStringsSep "-" (package: package.revision) sortedPackages; | ||
| src = map (package: | ||
| if os != null && builtins.hasAttr os package.archives then package.archives.${os} else package.archives.all | ||
| ) packages; | ||
| nativeBuildInputs = [ unzip ] ++ nativeBuildInputs; | ||
| preferLocalBuild = true; | ||
|
|
||
| unpackPhase = '' | ||
| buildDir=$PWD | ||
| i=0 | ||
| for srcArchive in $src; do | ||
| extractedZip="extractedzip-$i" | ||
| i=$((i+1)) | ||
| cd "$buildDir" | ||
| mkdir "$extractedZip" | ||
| cd "$extractedZip" | ||
| unpackFile "$srcArchive" | ||
| done | ||
| ''; | ||
|
|
||
| installPhase = lib.concatStrings (lib.imap0 (i: package: '' | ||
| cd $buildDir/extractedzip-${toString i} | ||
|
|
||
| # Most Android Zip packages have a root folder, but some don't. We unpack | ||
| # the zip file in a folder and we try to discover whether it has a single root | ||
| # folder. If this is the case, we adjust the current working folder. | ||
| if [ "$(find . -mindepth 1 -maxdepth 1 -type d | wc -l)" -eq 1 ]; then | ||
| cd "$(find . -mindepth 1 -maxdepth 1 -type d)" | ||
| fi | ||
| extractedZip="$PWD" | ||
|
|
||
| packageBaseDir=$out/libexec/android-sdk/${package.path} | ||
| mkdir -p $packageBaseDir | ||
| cd $packageBaseDir | ||
| cp -a $extractedZip/* . | ||
| ${patchesInstructions.${package.name}} | ||
| '') packages); | ||
|
|
||
| # Some executables that have been patched with patchelf may not work any longer after they have been stripped. | ||
| dontStrip = true; | ||
| dontPatchELF = true; | ||
| dontAutoPatchelf = true; | ||
|
|
||
| meta = { | ||
| description = lib.concatMapStringsSep "\n" (package: package.displayName) packages; | ||
| } // meta; | ||
| } // extraParams) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.