androidenv: Support deploying multiple packages in one derivation#208380
Merged
Artturin merged 4 commits intoNixOS:masterfrom Jan 11, 2023
Merged
Conversation
Contributor
Author
|
Hey @numinit, please review :) Thank you. |
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Can you prefix these PRs and commit messages with "androidenv:" so we know which component it is? |
numinit
reviewed
Dec 30, 2022
numinit
requested changes
Dec 30, 2022
hadilq
changed the title
hadilq
force-pushed
the
androidenv/support-deplying-multiple-packages-in-one-derivation
branch
from
b45d61e to
bceccb7
Compare
13 tasks
numinit
approved these changes
Dec 31, 2022
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1649 |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Contributor
Author
|
@SuperSandro2000, @Artturin is there anything else left in this PR to block it to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Support deploying multiple packages in one derivation. This will be needed in the future PRs that wants to solve a problem with
avdmanager.This is a part of #208047.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes